Fix/#118 매칭을 신청했으나, 매칭되지 않은 사용자의 매칭 상태 변경기능 추가 #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ticipants로 매칭된 파트너가 있을때만 알림과 채팅방 개설 이벤트를 발행하도록 기능 수정
suhyun0918
commented
Jun 7, 2024
Comment on lines
+111
to
119
| if (hasMatchedParticipants(participants)) { | ||
| eventPublisher.createChatRoom(participants); | ||
| eventPublisher.sendNotification(participants); | ||
| } | ||
| } | ||
|
|
||
| private boolean hasMatchedParticipants(List<Participant> participants) { | ||
| return !participants.stream().filter(Participant::hasPartner).toList().isEmpty(); | ||
| } |
There was a problem hiding this comment.
fcm 알림을 보낼때, 보낼 대상이 한명도 없으면 에러가 터져서 추가한 메서드 입니다!
이번 회차에 매칭된 사용자들이 없으면 채팅방 생성 이벤트 및 알림 이벤트는 호출도 하지 않도록 설계했습니다!
Comment on lines
+108
to
+110
| participants.stream() | ||
| .filter(participant -> !participant.hasPartner()) | ||
| .forEach(Participant::expireMatch); |
There was a problem hiding this comment.
이번에 추가된 부분입니다~
매칭 되지 않은 사용자들의 매칭 신청을 만료 시키는 로직이에용
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤨 Motivation
🔑 Key Changes
🙏 To Reviewers