Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Gemma <[email protected]>
  • Loading branch information
Razz4780 and gememma authored Feb 7, 2025
1 parent ab3e69b commit cc6a64b
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
8 changes: 4 additions & 4 deletions mirrord/agent/env/src/envs.rs
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@ pub const NETWORK_INTERFACE: CheckedEnv<String> = CheckedEnv::new("AGENT_NETWORK
/// Enables Prometheus metrics export point and sets its address.
pub const METRICS: CheckedEnv<SocketAddr> = CheckedEnv::new("MIRRORD_AGENT_METRICS");

/// Used to inform the agent that mesh is present in the target pod.
/// Used to inform the agent that the target pod is in a mesh.
pub const IN_SERVICE_MESH: CheckedEnv<bool> = CheckedEnv::new("MIRRORD_AGENT_IN_SERVICE_MESH");

/// Used to inform the agent that istio cni mesh is present in the target pod.
/// Used to inform the agent that the target pod is in an Istio CNI mesh.
pub const ISTIO_CNI: CheckedEnv<bool> = CheckedEnv::new("MIRRORD_AGENT_ISTIO_CNI");

/// Instructs the agent to flush connections when adding new iptables rules.
Expand All @@ -32,7 +32,7 @@ pub const STEALER_FLUSH_CONNECTIONS: CheckedEnv<bool> =
/// iptables.
pub const NFTABLES: CheckedEnv<bool> = CheckedEnv::new("MIRRORD_AGENT_NFTABLES");

/// Instructs the agent to produces logs in JSON format.
/// Instructs the agent to produce logs in JSON format.
pub const JSON_LOG: CheckedEnv<bool> = CheckedEnv::new("MIRRORD_AGENT_JSON_LOG");

/// Enables IPv6 support in the agent.
Expand All @@ -49,5 +49,5 @@ pub const POD_IPS: CheckedEnv<Vec<IpAddr>> = CheckedEnv::new("MIRRORD_AGENT_POD_

/// Sets agent log level.
///
/// Should follow `tracing`` format, e.g `mirrord=trace`.
/// Should follow `tracing` format, e.g `mirrord=trace`.
pub const LOG_LEVEL: CheckedEnv<String> = CheckedEnv::new("RUST_LOG");
2 changes: 1 addition & 1 deletion mirrord/agent/env/src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//! This crate contains definition of the mirrord-agent environment prepared in its Pod spec.
//! This crate defines the mirrord-agent environment as it is prepared in its Pod spec.
//!
//! Beware that any changes made here must be backward compatible (except for changes to
//! [`mesh::MeshVendor`]).
Expand Down

0 comments on commit cc6a64b

Please sign in to comment.