Skip to content

Commit

Permalink
Improved warning message
Browse files Browse the repository at this point in the history
  • Loading branch information
Razz4780 committed Feb 10, 2025
1 parent 01b2c9c commit 2781db1
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
1 change: 1 addition & 0 deletions changelog.d/+targetless-namespace-warning.changed.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Improved the warning produced when the user specifies agent namespace for a targetless run.
5 changes: 4 additions & 1 deletion mirrord/config/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -521,7 +521,10 @@ impl LayerConfig {
}

if self.agent.namespace.is_some() {

Check warning on line 523 in mirrord/config/src/lib.rs

View workflow job for this annotation

GitHub Actions / lint

Diff in /home/runner/work/mirrord/mirrord/mirrord/config/src/lib.rs
context.add_warning("Agent namespace is ignored in targetless runs".into());
context.add_warning(
"Agent namespace is ignored in targetless runs. \
To specify a namespace for a targetless run, use target namespace.".into()
);
}
}

Expand Down

0 comments on commit 2781db1

Please sign in to comment.