Skip to content

[GSSoC'26] fix(batch): return unknown for malformed expiry dates #1803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dipexplorer merged 3 commits into from
Jun 15, 2026
+195 −0
Merged

[GSSoC'26] fix(batch): return unknown for malformed expiry dates #1803

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1ca4072
fix(batch): return unknown for malformed expiry dates
vipul674 Jun 13, 2026
7922e42
Merge branch 'main' into 1799-fix-expiry-status-validation
vipul674 Jun 14, 2026
a1c2062
test(batch): add 5 expiry status test cases
vipul674 Jun 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions apps/api/src/routes/batch.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ function getExpiryStatus(expiryDate: string | null): "green" | "yellow" | "red"
if (!expiryDate) return "unknown";
const now = new Date();
const expiry = new Date(expiryDate);
if (isNaN(expiry.getTime())) return "unknown";
const diffMs = expiry.getTime() - now.getTime();
const diffMonths = diffMs / (1000 * 60 * 60 * 24 * 30);

Expand Down
194 changes: 194 additions & 0 deletions apps/api/tests/batch.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,4 +236,198 @@ describe("GET /api/verify/batch/:batchNumber", () => {
expect(mockedSupabase.eq).toHaveBeenNthCalledWith(1, "batch_number", "bn2024001");
expect(mockedSupabase.eq).toHaveBeenNthCalledWith(2, "batch_number", "bn2024001");
});

it("returns unknown expiry_status when expiry_date is null", async () => {
mockedSupabase.maybeSingle.mockResolvedValueOnce({
data: {
batch_number: "BN-NULL-EXPIRY",
manufacturing_date: "2026-01-10",
expiry_date: null,
recall_status: "none",
quantity_produced: 5000,
medicine: {
id: "medicine-1",
brand_name: "SahiCure",
generic_name: "Paracetamol",
cdsco_approval_status: "Approved",
is_counterfeit_alert: false,
},
manufacturer: {
name: "Sahi Pharma Ltd",
license_number: "LIC-12345",
address: "Industrial Area",
city: "Ahmedabad",
state: "Gujarat",
pincode: "380001",
phone: "07912345678",
email: "quality@sahipharma.example",
website: "https://sahipharma.example",
gmp_certified: true,
location: { coordinates: [72.5714, 23.0225] },
},
},
error: null,
});

const response = await request(app).get("/api/verify/batch/BN-NULL-EXPIRY");

expect(response.status).toBe(200);
expect(response.body.expiry_status).toBe("unknown");
});

it("returns unknown expiry_status for malformed expiry_date", async () => {
mockedSupabase.maybeSingle.mockResolvedValueOnce({
data: {
batch_number: "BN-BAD-DATE",
manufacturing_date: "2026-01-10",
expiry_date: "not-a-date",
recall_status: "none",
quantity_produced: 5000,
medicine: {
id: "medicine-1",
brand_name: "SahiCure",
generic_name: "Paracetamol",
cdsco_approval_status: "Approved",
is_counterfeit_alert: false,
},
manufacturer: {
name: "Sahi Pharma Ltd",
license_number: "LIC-12345",
address: "Industrial Area",
city: "Ahmedabad",
state: "Gujarat",
pincode: "380001",
phone: "07912345678",
email: "quality@sahipharma.example",
website: "https://sahipharma.example",
gmp_certified: true,
location: { coordinates: [72.5714, 23.0225] },
},
},
error: null,
});

const response = await request(app).get("/api/verify/batch/BN-BAD-DATE");

expect(response.status).toBe(200);
expect(response.body.expiry_status).toBe("unknown");
});

it("returns red expiry_status for an expired batch", async () => {
mockedSupabase.maybeSingle.mockResolvedValueOnce({
data: {
batch_number: "BN-EXPIRED",
manufacturing_date: "2020-01-10",
expiry_date: "2024-01-01",
recall_status: "none",
quantity_produced: 5000,
medicine: {
id: "medicine-1",
brand_name: "SahiCure",
generic_name: "Paracetamol",
cdsco_approval_status: "Approved",
is_counterfeit_alert: false,
},
manufacturer: {
name: "Sahi Pharma Ltd",
license_number: "LIC-12345",
address: "Industrial Area",
city: "Ahmedabad",
state: "Gujarat",
pincode: "380001",
phone: "07912345678",
email: "quality@sahipharma.example",
website: "https://sahipharma.example",
gmp_certified: true,
location: { coordinates: [72.5714, 23.0225] },
},
},
error: null,
});

const response = await request(app).get("/api/verify/batch/BN-EXPIRED");

expect(response.status).toBe(200);
expect(response.body.expiry_status).toBe("red");
});

it("returns yellow expiry_status for near-expiry batch (within 6 months)", async () => {
const nearFuture = new Date();
nearFuture.setMonth(nearFuture.getMonth() + 3);
const nearExpiryDate = nearFuture.toISOString().slice(0, 10);

mockedSupabase.maybeSingle.mockResolvedValueOnce({
data: {
batch_number: "BN-NEAR-EXPIRY",
manufacturing_date: "2025-06-01",
expiry_date: nearExpiryDate,
recall_status: "none",
quantity_produced: 5000,
medicine: {
id: "medicine-1",
brand_name: "SahiCure",
generic_name: "Paracetamol",
cdsco_approval_status: "Approved",
is_counterfeit_alert: false,
},
manufacturer: {
name: "Sahi Pharma Ltd",
license_number: "LIC-12345",
address: "Industrial Area",
city: "Ahmedabad",
state: "Gujarat",
pincode: "380001",
phone: "07912345678",
email: "quality@sahipharma.example",
website: "https://sahipharma.example",
gmp_certified: true,
location: { coordinates: [72.5714, 23.0225] },
},
},
error: null,
});

const response = await request(app).get("/api/verify/batch/BN-NEAR-EXPIRY");

expect(response.status).toBe(200);
expect(response.body.expiry_status).toBe("yellow");
});

it("returns green expiry_status for a future expiry date", async () => {
mockedSupabase.maybeSingle.mockResolvedValueOnce({
data: {
batch_number: "BN-FUTURE",
manufacturing_date: "2026-01-10",
expiry_date: "2099-12-31",
recall_status: "none",
quantity_produced: 5000,
medicine: {
id: "medicine-1",
brand_name: "SahiCure",
generic_name: "Paracetamol",
cdsco_approval_status: "Approved",
is_counterfeit_alert: false,
},
manufacturer: {
name: "Sahi Pharma Ltd",
license_number: "LIC-12345",
address: "Industrial Area",
city: "Ahmedabad",
state: "Gujarat",
pincode: "380001",
phone: "07912345678",
email: "quality@sahipharma.example",
website: "https://sahipharma.example",
gmp_certified: true,
location: { coordinates: [72.5714, 23.0225] },
},
},
error: null,
});

const response = await request(app).get("/api/verify/batch/BN-FUTURE");

expect(response.status).toBe(200);
expect(response.body.expiry_status).toBe("green");
});
});
Loading