bittensor-core e2es#2850
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
🛡️ AI Review — Skeptic (security review)VERDICT: SAFE VERY HIGH scrutiny: 10-day-old account with 0 public repos and 11 lifetime contributions; mitigated by repository write access, matching author/committer identity, and no Gittensor association found. Branch: bittensor-core-e2es → bittensor-core-exploration. Static analysis found no runtime changes, suspicious external dependencies, trusted AI-review instruction modifications, backdoors, or security vulnerabilities. The workflow quotes manifest-derived test names, and the only dependency addition is an existing workspace crate. FindingsNo findings. ConclusionNo malicious behavior or security vulnerability was found in the current diff. 🔍 AI Review — Auditor (domain review)VERDICT: 👍 UNKNOWN gittensor association; very new contributor with repository write access, so the large SDK and CI surface received heightened static scrutiny. The prior host-feature and fast-runtime-description concerns remain resolved. No substantive duplicate PR was identified, and no spec-version bump applies to this feature-branch base. One low-severity CI coverage gap remains: edits to the TypeScript E2E workflow no longer select that workflow’s own E2E job. No runtime confirmation was needed, and no auto-fixes were applied. Findings
ConclusionThe SDK migration and its Rust E2E coverage remain internally consistent, with only a small workflow self-testing gap to fix. Approved with the inline correction. |
|
🔄 AI review updated — Skeptic: VULNERABLE |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👎 |
|
🔄 AI review updated — Skeptic: VULNERABLE |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👎 |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
| set -euo pipefail | ||
| files=$(gh api "repos/$GITHUB_REPOSITORY/pulls/$PR_NUMBER/files" --paginate --jq '.[].filename') | ||
| pattern='^(ts-tests|common|node|pallets|precompiles|primitives|runtime|support|chain-extensions|src|vendor)/|^(Cargo\.(toml|lock)|build\.rs|rust-toolchain\.toml)$|^\.github/workflows/typescript-e2e\.yml$' | ||
| # SDK-only lockfile movement is covered by SDK checks; do not run |
There was a problem hiding this comment.
[LOW] Workflow edits no longer exercise this E2E job
The filter dropped .github/workflows/typescript-e2e.yml itself. As a result, a PR that only changes this workflow—including this filter or the E2E steps below—reports e2e=false, so broken workflow changes can merge without exercising the job they modify. Keep SDK-only Cargo.lock changes excluded, but include the workflow file as an input.
| # SDK-only lockfile movement is covered by SDK checks; do not run | |
| pattern='^(ts-tests|common|node|pallets|precompiles|primitives|runtime|support|chain-extensions|src|vendor)/|^(Cargo\.toml|build\.rs|rust-toolchain\.toml)$|^\.github/workflows/typescript-e2e\.yml$' |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
1 participant
Motivation
Provide native Rust coverage for the
bittensor-coreSDK and migrate the Bittensor end-to-end suite to a metadata-driven Rust harness. This validates chain reads, transaction construction, policy enforcement, submission outcomes, and higher-level SDK behavior against the repository's localnet image.What changed
sdk/bittensor-core/src/client.rs, including pinned reads, runtime API calls, storage queries, fee estimation, signed submission, receipt decoding, snapshots, block streaming, and MEV-shielded submission.sdk/bittensor-core/src/transaction.rs.sdk/bittensor-core/tests/..github/workflows/check-bittensor-e2e-tests.ymlto verify manifest completeness, compile the Rust E2E binary once, build the localnet image, and execute each manifest case independently with one retry.Behavioral impact
The Rust SDK gains native chain access and transaction execution APIs. The E2E workflow now exercises the Rust suite rather than the prior test discovery/execution path. Runtime and pallet behavior are unchanged.
Migration and spec version
No storage migration is required. This PR does not modify runtime or pallet code, and its
bittensor-core-explorationbase has no network spec-version check, so nospec_versionbump is required.Testing
The workflow compiles
bittensor-core-py, compiles the Rust E2E target, verifies that all 113 manifest entries exactly match compiled tests, and runs each test against the fast-runtime localnet artifact, matching the runtime configuration used by the previous Python E2E workflow.