Subnet sale offer by l0r1s · Pull Request #2745 · RaoFoundation/subtensor

l0r1s · 2026-06-10T22:21:27Z

Summary

This PR adds subnet sale offers to the Subtensor pallet.

The goal is to let a subnet owner announce that a subnet is for sale, optionally
restricted to a specific buyer coldkey. Once an offer exists, a later crowdloan
lease flow can target that offer, pay the seller, and transform the subnet into a
lease atomically.

Creating an offer stores the sale terms by netuid and freezes the seller coldkey
and current subnet owner hotkey while the offer is active. This prevents the seller
from mutating the relevant accounts during the sale. The seller or root can cancel
the offer, and sale-offer state is also cleaned up if the subnet is removed.

Sale offer identity

Each offer is assigned a unique, monotonically increasing SaleOfferId. Offers are
keyed by netuid, so the id lets a consumer (such as the future crowdloan lease
flow) bind to the exact offer it agreed to: if the seller cancels and recreates the
offer with different terms, the recreated offer carries a new id and the stale
binding no longer matches, rather than being silently satisfied by an offer with
modified terms.

Freeze enforcement

A CheckSubnetSale dispatch extension rejects frozen sale accounts at dispatch time:

A frozen seller coldkey may only cancel its sale offer; every other call is rejected.
A frozen owner hotkey is fully locked and may submit no calls.
Root bypasses the guard, and non-signed origins pass through.

Because this is a dispatch extension (not a transaction extension), the check fires
at every call.dispatch(origin) site, including indirectly dispatched calls (e.g.
proxy) with the resolved signer, so the freeze cannot be bypassed by wrapping a call
in another dispatch layer.

To keep the freeze consistent, swap_hotkey also refuses to swap a hotkey that is
currently frozen by a sale offer, which would otherwise move the subnet owner hotkey
out from under the offer (the owner hotkey can be owned by a coldkey other than the
frozen seller, so the coldkey freeze alone does not cover this).

Same-account owner

When the subnet owner coldkey and owner hotkey are the same account, only the coldkey
is frozen. Freezing the same account in the hotkey map as well would block
cancellation (a coldkey action) and permanently lock the seller out of their own
offer.

Other changes

New storage: SubnetSaleOffers, SubnetSaleFrozenColdkeys,
SubnetSaleFrozenHotkeys, and the NextSubnetSaleOfferId counter.
New create_sale_offer and cancel_sale_offer extrinsics, with the associated
events and errors.
Benchmarks and weights for both extrinsics and for the CheckSubnetSale dispatch
extension.
Unit tests covering offer creation/cancellation, key freezing, cleanup on subnet
removal, the same-account case, the swap_hotkey interaction, and the
dispatch-extension guard (including proxied and nested-proxy dispatch).

Follow-up

The buyer/finalize side is intentionally not included yet. When it lands,
finalization should re-verify that the subnet owner coldkey and hotkey still match
the values snapshotted in the offer (alongside the SaleOfferId) as a fail-safe
against any owner-identity drift during the sale.

github-actions

AI review — see the sticky summary comment for the verdict and the inline comments below for specific findings.

github-actions · 2026-06-10T22:25:59Z

🛡️ AI Review — Skeptic (security review)

VERDICT: SAFE

BASELINE scrutiny: l0r1s has write permission, an established 2018 account, substantial prior contribution history, no Gittensor allowlist match found, and commit authors match except the benchmark bot commit. Branch subnet-sale-offer -> devnet-ready.

No .github/ai-review/*, .github/copilot-instructions.md, dependency, lockfile, or build-script changes are present. The current diff keeps sale-offer creation owner-signed, cancellation seller-or-root only, blocks frozen accounts through the new dispatch extension, excludes sale-offer creation from broad proxy allowlists, and includes generated/fallback weights for the new storage reads and writes.

Findings

No findings.

Prior-comment reconciliation

82c134bf: addressed — The generated create_sale_offer weight documents NextSubnetSaleOfferId and charges 8 reads / 4 writes.
610bde28: addressed — The fallback create_sale_offer weight also documents NextSubnetSaleOfferId and charges 8 reads / 4 writes.

Conclusion

I found no malicious indicators or security vulnerabilities in the current diff. The prior sale-offer weight findings remain addressed.

🔍 AI Review — Auditor (domain review)

VERDICT: 👍

Gittensor: LIKELY by repo-history heuristic; author has write access and substantial recent subtensor contribution history, so review focused on runtime correctness and permission boundaries.

PR body is substantive and matches the implementation. The current diff keeps create_sale_offer owner-signed and excluded from broad proxy allowlists, leaves cancel_sale_offer available so frozen sellers can exit, wires CheckSubnetSale into the transaction and nested-dispatch paths, and covers offer lifecycle, freezes, cleanup, swap-hotkey interaction, and proxy behavior with focused tests.

No duplicate-work recommendation from the cached overlapping PR list. Auto-fix: no workspace changes. I attempted the devnet spec_version RPC check, but DNS resolution for dev.chain.opentensor.ai failed in this environment; local/base spec_version are both 426, so I left the worktree unchanged. I did not run targeted tests because no finding required runtime confirmation.

Findings

No findings.

Prior-comment reconciliation

232a1ea5: addressed — create_sale_offer is isolated in SubnetSaleCalls and denied to broad proxy types; only direct calls or Any can create sale offers, while cancellation remains broadly available.

Conclusion

Approving: the previously blocking proxy boundary remains fixed, and the sale-offer state transitions have appropriate guard wiring, weights, and test coverage. No current domain blocker found.

github-actions · 2026-06-10T22:26:07Z

🔄 AI review updated — Skeptic: VULNERABLE

github-actions

AI review — see the sticky summary comment for the verdict and the inline comments below for specific findings.

github-actions · 2026-06-10T22:29:30Z

🔄 AI review updated — Skeptic: VULNERABLE

github-actions

AI review — see the sticky summary comment for the verdict and the inline comments below for specific findings.

github-actions · 2026-07-01T17:18:59Z

🔄 AI review updated — Skeptic: VULNERABLE

github-actions

AI review — see the sticky summary comment for the verdict and the inline comments below for specific findings.

github-actions · 2026-07-05T15:28:05Z

🔄 AI review updated — Skeptic: SAFE Auditor: 👎

github-actions

AI review — see the sticky summary comment for the verdict and the inline comments below for specific findings.

github-actions · 2026-07-05T17:15:54Z

🔄 AI review updated — Skeptic: VULNERABLE

github-actions

AI review — see the sticky summary comment for the verdict and the inline comments below for specific findings.

github-actions · 2026-07-05T17:30:05Z

🔄 AI review updated — Skeptic: VULNERABLE

github-actions

AI review — see the sticky summary comment for the verdict and the inline comments below for specific findings.

github-actions · 2026-07-05T18:01:18Z

🔄 AI review updated — Skeptic: VULNERABLE

…into subnet-sale-offer

github-actions

AI review — see the sticky summary comment for the verdict and the inline comments below for specific findings.

github-actions · 2026-07-06T12:44:21Z

🔄 AI review updated — Skeptic: SAFE Auditor: 👎

github-actions · 2026-07-06T13:45:07Z

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

github-actions · 2026-07-08T12:43:34Z

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

vercel · 2026-07-09T14:17:28Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
subtensor	Ready	Preview, Comment	Jul 9, 2026 2:17pm

l0r1s added 8 commits June 10, 2026 18:12

Merge mock and mock_high_ed

fb47d0c

Added SubnetSaleOffers and frozen coldkey/hotkey storage

485f4bf

Added extrinsic to create/cancel sale offer

25d83ba

Cleanup sale offer on subnet removal

5e9801f

Added tests

a93d4a9

Added CheckSubnetSale dispatch extension

35bf96b

Added benchmarks and weights placeholder

54cf502

Merge branch 'devnet-ready' into subnet-sale-offer

4e25ad2

github-actions Bot reviewed Jun 10, 2026

View reviewed changes

Comment thread pallets/subtensor/src/guards/check_subnet_sale.rs Outdated

Added creation date for later use

79fbaad

github-actions Bot reviewed Jun 10, 2026

View reviewed changes

Comment thread pallets/subtensor/src/guards/check_subnet_sale.rs Outdated

l0r1s requested review from JohnReedV, evgeny-s, gztensor, open-junius and sam0x17 June 10, 2026 22:31

github-actions Bot mentioned this pull request Jun 29, 2026

Apply tx & dispatch extensions conditionally #2812

Merged

Merge branch 'devnet-ready' into subnet-sale-offer

175bd10

github-actions Bot reviewed Jul 1, 2026

View reviewed changes

Comment thread pallets/subtensor/src/guards/check_subnet_sale.rs Outdated

Fix some issues

d664ff9

github-actions Bot reviewed Jul 5, 2026

View reviewed changes

Comment thread pallets/subtensor/src/guards/check_subnet_sale.rs Outdated

Comment thread pallets/subtensor/src/weights.rs Outdated

Added SaleOfferId and harden protection against swaps

1733a3b

github-actions Bot reviewed Jul 5, 2026

View reviewed changes

Comment thread pallets/subtensor/src/weights.rs Outdated

Comment thread pallets/subtensor/src/weights.rs Outdated

Add missing benchmark for extension

36752d1

github-actions Bot reviewed Jul 5, 2026

View reviewed changes

Comment thread pallets/subtensor/src/weights.rs Outdated

Comment thread pallets/subtensor/src/weights.rs Outdated

cargo fmt

54a4601

github-actions Bot reviewed Jul 5, 2026

View reviewed changes

Comment thread pallets/subtensor/src/weights.rs Outdated

Comment thread pallets/subtensor/src/weights.rs Outdated

l0r1s added apply-benchmark-patch skip-cargo-audit This PR fails cargo audit but needs to be merged anyway labels Jul 6, 2026

auto-update benchmark weights

6fe155c

github-actions Bot removed the apply-benchmark-patch label Jul 6, 2026

l0r1s added 2 commits July 6, 2026 13:36

Add sale offer calls to SubtensorCommonCalls

f327d37

Merge remote-tracking branch 'refs/remotes/origin/subnet-sale-offer' …

9cd2a95

…into subnet-sale-offer

github-actions Bot reviewed Jul 6, 2026

View reviewed changes

Comment thread runtime/src/proxy_filters/call_groups.rs Outdated

l0r1s added 2 commits July 6, 2026 14:11

Sale offer creation excluded from every group and cancel as common

e97ff3a

cargo fmt

bf1b3c8

UnArbosSix previously approved these changes Jul 7, 2026

View reviewed changes

Merge branch 'devnet-ready' into subnet-sale-offer

3858895

l0r1s dismissed UnArbosSix’s stale review via 3858895 July 8, 2026 12:36

Merge branch 'devnet-ready' into subnet-sale-offer

d5e046f

vercel Bot deployed to Preview July 9, 2026 14:17 View deployment

Uh oh!

Conversation

l0r1s commented Jun 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Sale offer identity

Freeze enforcement

Same-account owner

Other changes

Follow-up

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Jun 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🛡️ AI Review — Skeptic (security review)

Findings

Prior-comment reconciliation

Conclusion

🔍 AI Review — Auditor (domain review)

Findings

Prior-comment reconciliation

Conclusion

Uh oh!

github-actions Bot commented Jun 10, 2026

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Jun 10, 2026

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Jul 1, 2026

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jul 5, 2026

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jul 5, 2026

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jul 5, 2026

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jul 5, 2026

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Jul 6, 2026

Uh oh!

github-actions Bot commented Jul 6, 2026

Uh oh!

github-actions Bot commented Jul 8, 2026

Uh oh!

vercel Bot commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

l0r1s commented Jun 10, 2026 •

edited

Loading

github-actions Bot commented Jun 10, 2026 •

edited

Loading

vercel Bot commented Jul 9, 2026 •

edited

Loading