Better MEV shield errors#23
Open
l0r1s wants to merge 6 commits into
Open
Conversation
sam0x17
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shield error propagation
When a shielded transaction fails (decryption failure, inner tx decode error, inner tx validation failure), the proposer now includes an error extrinsic in the block alongside the wrapper. This gives SDK and wallet developers on-chain feedback about what went wrong, instead of silently dropping the inner transaction.
What changed
ShieldErrortype hierarchy with sub-enums:ParsingError,WrapperExtrinsicError,DecryptionError,InnerExtrinsicErrorwith human-readable error messages.#[api_version(2)]) so new nodes work with both old and new runtimesmake_shield_error_extrinsicruntime API for the proposer to build error extrinsicsreport_shield_errorinto the block when the shielded transaction failsShieldedTransaction::parsereturnsResultwith specific parsing errors instead ofOptionOn-chain outcomes for a shielded tx
ShieldedTxFailedeventErrors that cannot be propagated on-chain
Two failure cases can't produce an on-chain error because the wrapper itself never gets included:
If a user's
submit_encryptedwrapper never appears on-chain, it's one of these two cases.Upgrade path
setCode— node detects v2 and enables error reporting