test: Add tests for /api/user/feed endpoint #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Integration of comprehensive functional tests (`TestUserPromoFeed`) that verify core endpoint behaviors:
- Accurate user-specific promo targeting based on age and country.
- Correct dynamic calculation of promo 'active' status (considering dates, usage counts, and unique code availability).
- Effective filtering via `active` (boolean) and `category` (case-insensitive) query parameters.
- Proper pagination functionality using `limit` and `offset`, including `X-Total-Count` header validation.
- Verification of response data structure, ensuring exclusion of sensitive promo code values.
- Correct reflection of promo data updates (e.g., a promo becoming inactive after an edit) in the feed.
2. Addition of new focused validation tests (`TestUserPromoFeed`) using parameterized inputs to cover edge cases and invalid requests:
- Authentication checks, specifically ensuring `401 Unauthorized` for requests lacking a token.
- Rigorous validation of query parameters (`limit`, `offset`, `category`, `active`):
- Invalid data types and formats (e.g., non-numeric for `limit`/`offset`, non-boolean for `active`).
- Values outside defined constraints (e.g., negative `limit`/`offset`, category string length violations).
- Empty string inputs for parameters that require specific formats.
- Rejection of requests containing unexpected or unsupported query parameters, returning a `400 Bad Request`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration of comprehensive functional tests (
TestUserPromoFeed) that verify core endpoint behaviors:active(boolean) andcategory(case-insensitive) query parameters.limitandoffset, includingX-Total-Countheader validation.Addition of new focused validation tests (
TestUserPromoFeed) using parameterized inputs to cover edge cases and invalid requests:401 Unauthorizedfor requests lacking a token.limit,offset,category,active):limit/offset, non-boolean foractive).limit/offset, category string length violations). - Empty string inputs for parameters that require specific formats.400 Bad Request.