WIP: Update Send-SlackAPI to support cursor-based pagination#91
Open
rkeithhill wants to merge 1 commit into
Open
WIP: Update Send-SlackAPI to support cursor-based pagination#91rkeithhill wants to merge 1 commit into
rkeithhill wants to merge 1 commit into
Conversation
68bc48f to
635ff39
Compare
Author
|
@RamblingCookieMonster Any thoughts on this PR? I think I need to switch the parameter name from |
Owner
|
Agreed on all counts! Alias to avoid breaking change, remove ad hoc paging if you can offload it : D thank you so much for putting the time into this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #88
This is a work in progress because while Get-SlackUser now retrieves all users. I'm not sure what we want to do about the other commands that implement paging themselves. There are also two forms of paging on Slack - an older approach called class paging and a new approach called cursor-based pagination. I've implemented the latter in Send-SlackAPI. Also, with Get-SlackUser I'm not exposing any pagination parameters yet. I think most of the time, folks just want to get all users. That said, we could expose parameters similar to the other commands.