Open
Conversation
Added sv_maprotationcurrent check
diamante0018
reviewed
Feb 3, 2026
| { | ||
| // Parse format: "gametype sd map mp_bloc ..." | ||
| var pattern = @"^\s*(?:gametype\s+([a-z]+)\s+)?map\s+([a-z0-9_.-]+)\s*(.*)$"; | ||
| var match = Regex.Match(currentRotation.Value.ToLower(), pattern, RegexOptions.IgnoreCase); |
Collaborator
There was a problem hiding this comment.
Wether or not to use regex to parse the map rotation is a question I'll leave to the maintainers
(the clients do not waste resources using regex: see iw4x-client map rotation.cpp, it's just easier to split the string by spaces and read the first token pair for map ).
Anyhow, you are already ignoring the case with the regex function so calling tolower() is a wasteful operation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added sv_maprotationcurrent check
when using the !nm command, the map was not detected correctly, but it is now fixed and works well