Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dubbing access #48

Closed

Conversation

austinbhale
Copy link
Contributor

Thank you for this project! I added in some dubbing functionality, since it's been launched for all price tiers in May

  • feat: dubbing access; upload, asynchronous partial download, & transcriptions
  • feat: dubbing unit test on the sample audio file. confirmed for videos too, you just might need to enable the watermark depending on your price tier
  • refactor: upgrade to net8.0
  • refactor: treat warnings as errors set to false for sharing with other people's setups

…riptions

feat: dubbing unit test on the audio file
refactor: upgrade to net8.0
refactor: treat warnings as errors set to false for sharing with other people's setups
@StephenHodgson
Copy link
Member

Thanks @austinbhale! I'll check it out shortly.

Only initial feedback is to revert back to .net6. I wanted to keep support for that until it reaches EOL

@StephenHodgson
Copy link
Member

Also please check your tab settings. Should be 4 spaces.

@StephenHodgson
Copy link
Member

Please revert all changes to .csproj files

@austinbhale
Copy link
Contributor Author

Please revert all changes to .csproj files

Could we keep the added net8.0 framework though? I can revert the treat warnings as errors as well

@StephenHodgson
Copy link
Member

StephenHodgson commented Jul 5, 2024

Could we keep the added net8.0 framework though?

It will automatically be supported with net6.0 reference.

https://www.nuget.org/packages/ElevenLabs-DotNet/#supportedframeworks-body-tab

@austinbhale
Copy link
Contributor Author

I gotcha, keeping it compatible for net8.0 like that sounds good. Just wanted to take advantage of perf updates to the CLR, but prob no noticeable difference here

@austinbhale
Copy link
Contributor Author

One more thing is I'll make a test for an online URL since that's supposed to work too

@StephenHodgson
Copy link
Member

StephenHodgson commented Jul 5, 2024

I gotcha, keeping it compatible for net8.0 like that sounds good. Just wanted to take advantage of perf updates to the CLR, but prob no noticeable difference here

When your actual project targets .net 8 it should update the CLR automatically

@austinbhale
Copy link
Contributor Author

Ok it works for online content too! I should be done making changes until your testing & review :) Feel free to edit anything & swap out the YouTube video, I just chose theirs randomly

@StephenHodgson
Copy link
Member

StephenHodgson commented Jul 5, 2024

looks great. My only real Change Request is to make any return types from StartDubbingAsync a defined object.

Similar to VoiceClip

@austinbhale
Copy link
Contributor Author

Thanks for the suggestion! I think that looks much cleaner for deserialization too

@austinbhale
Copy link
Contributor Author

Hi! Any updates on integrating this?

@StephenHodgson
Copy link
Member

Sorry been a bit busy. Working on some other edits as well but got overloaded with work.

Overall looks good and I'll get this in as soon as I finish up adding the other endpoints for sfx

@austinbhale
Copy link
Contributor Author

Awesome, looking forward to trying those out. No rush, can use a private NuGet till then. Thanks!

@StephenHodgson StephenHodgson changed the base branch from main to development July 21, 2024 16:13
@StephenHodgson StephenHodgson mentioned this pull request Jul 21, 2024
@StephenHodgson
Copy link
Member

@austinbhale You didn't give me edit access to your PR so I wasn't able to sync it with development, so I merged it into a new branch and opened a new PR #50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants