-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dubbing access #48
Dubbing access #48
Conversation
…riptions feat: dubbing unit test on the audio file refactor: upgrade to net8.0 refactor: treat warnings as errors set to false for sharing with other people's setups
Thanks @austinbhale! I'll check it out shortly. Only initial feedback is to revert back to .net6. I wanted to keep support for that until it reaches EOL |
Also please check your tab settings. Should be 4 spaces. |
refactor: spaces instead of tabs https://youtu.be/SsoOG6ZeyUI
Please revert all changes to .csproj files |
Could we keep the added net8.0 framework though? I can revert the treat warnings as errors as well |
It will automatically be supported with net6.0 reference. https://www.nuget.org/packages/ElevenLabs-DotNet/#supportedframeworks-body-tab |
I gotcha, keeping it compatible for net8.0 like that sounds good. Just wanted to take advantage of perf updates to the CLR, but prob no noticeable difference here |
One more thing is I'll make a test for an online URL since that's supposed to work too |
When your actual project targets .net 8 it should update the CLR automatically |
Ok it works for online content too! I should be done making changes until your testing & review :) Feel free to edit anything & swap out the YouTube video, I just chose theirs randomly |
looks great. My only real Change Request is to make any return types from Similar to |
…line with the API reference
Thanks for the suggestion! I think that looks much cleaner for deserialization too |
Hi! Any updates on integrating this? |
Sorry been a bit busy. Working on some other edits as well but got overloaded with work. Overall looks good and I'll get this in as soon as I finish up adding the other endpoints for sfx |
Awesome, looking forward to trying those out. No rush, can use a private NuGet till then. Thanks! |
@austinbhale You didn't give me edit access to your PR so I wasn't able to sync it with development, so I merged it into a new branch and opened a new PR #50 |
Thank you for this project! I added in some dubbing functionality, since it's been launched for all price tiers in May