Feat: useContext in Pencil's todo list #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashramwen
requested changes
Apr 3, 2022
|
|
||
| function Layout() { | ||
| const [currentPath, setCurrentPath] = useState(''); | ||
| const pathArr = useLocation().pathname.split('/senpai/'); | ||
| const path = pathArr[pathArr.length - 1]; |
There was a problem hiding this comment.
useMatch('senpai/:type')| return ( | ||
| <div className="min-h-screen w-full bg-stone-800"> | ||
| <h1 className="text-white text-2xl">Pencil's React workshop dashboard</h1> | ||
| <nav className="flex justify-around box-border bg-cyan-700"> | ||
| <Link |
There was a problem hiding this comment.
Comment on lines
+16
to
+17
| id={ADD_TODO} | ||
| name={ADD_TODO} |
Comment on lines
+75
to
+76
| const [inputValue, setInputValue] = useState(item.text); | ||
| const { updateTodo, toggleDataState, deleteItem } = useMethods(); |
There was a problem hiding this comment.
這兩行怎麼不在 EditArea 和 ButtonArea 呼叫就好?
| function EditArea({ item, methods, inputValue }) { | ||
| return ( | ||
| <div className={clsx('flex w-0 grow')}> | ||
| {!item.isEdit && ( |
Comment on lines
+46
to
+48
| {item.isDone ? ( | ||
| <p className={clsx('w-20 rounded-md', 'bg-stone-800 text-lime-300')}>Done</p> | ||
| ) : item.isEdit ? ( |
There was a problem hiding this comment.
這好複雜
但其實 isDone 跟 isEdit 並沒有交疊關係不是嗎?
{isEdit ? <.../> : <.../>}
{isDone ? <.../> : <.../> }| import { useState } from 'react'; | ||
| import Button from './Button'; | ||
|
|
||
| function TodoForm({ item, updateTodo, toggleDataState, deleteItem }) { |
| ); | ||
| } | ||
|
|
||
| export const useMethods = () => useContext(MethodContext); |
There was a problem hiding this comment.
全部東西都放在同一個檔案裡
context
custom hook
component
很複雜
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
終於....有勞了...
真相欸