feat: add huibizhang todolist #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashramwen
requested changes
Mar 21, 2022
There was a problem hiding this comment.
先醬
console 有 warnings 的話要清掉，不然 github action 在 deploy 的時候不會過
WARNING in src/pages/huibizhang/TodoList/TodoList.jsx
Line 18:9: 'save' is assigned a value but never used no-unused-vars
src/pages/huibizhang/TodoList/components/PostCreator.jsx
Line 23:6: React Hook useEffect has missing dependencies: 'content', 'pin', 'tags', and 'title'. Either include them or remove the dependency array react-hooks/exhaustive-deps| { | ||
| group: '功能', | ||
| showGroupName: false, | ||
| childs: [{ name: '待辦事項', link: '/' }], |
Comment on lines
+104
to
+109
| const current = Object.assign({}, todo); | ||
| current.title = postData.title; | ||
| current.content = postData.content; | ||
| current.pin = postData.pin; | ||
| current.tags = postData.tags; | ||
| return current; |
There was a problem hiding this comment.
現在可以用 spread operator
const current = {
...todo,
title: postData.title,
content: postData.content,
pin: postData.pin,
tags: postData.tags,
};There was a problem hiding this comment.
如果 postData 結構一樣的話，甚至可以
const current = { ...todo, ...postData };There was a problem hiding this comment.
看了下兩個只有差在 order，所以可以
const { order, ...restPostData } = postData;
const current = { ...todo, ...restPostData };| className="flex aspect-square h-full items-center justify-center rounded-full text-white hover:bg-white/30 dark:text-gray-200" | ||
| onClick={() => setDrawerOpened(true)} | ||
| > | ||
| <svg |
| className="xs:grid-cols-2 xs:gap-2 xs:space-y-0 grid grid-cols-1 space-y-2" | ||
| > | ||
| {posts.pins().map((todo) => { | ||
| return <Post key={todo.id} {...todo} open={[edit, setMode]}></Post>; |
There was a problem hiding this comment.
props 用 array 傳遞，要非常小心順序
我個人不是很常用
| {childs.map((child) => { | ||
| return ( | ||
| <label | ||
| for="groupItem" |
| pin: _pin, | ||
| tags: _tags, | ||
| order: 0, | ||
| }); |
There was a problem hiding this comment.
如果沒有每個 member 都建立一個 state，而是直接一個物件的話
就可以
addPost({
id: idGenerator(16),
order: 0,
...editData
});| const idGenerator = (length) => { | ||
| const key = ['abcdefghijklmnopqrstuvwxyz', 'ABCDEFGHIJKLMNOPQRSTUVWXYZ', '0123456789'].join(''); | ||
|
|
||
| var id = ''; |
| tagEditor | ||
| ? 'bg-gray-300 text-blue-600 dark:bg-gray-800 dark:text-blue-500' | ||
| : 'bg-white text-gray-500 dark:bg-gray-700 dark:text-gray-400', | ||
| ] |
There was a problem hiding this comment.
clsx 的寫法跟其他地方不太一致，建議一個專案都用一種模式
| }; | ||
|
|
||
| useEffect(() => { | ||
| setTodos(JSON.parse(window.localStorage.getItem('todos')) ?? [ |
| const [drawerOpened, setDrawerOpened] = useState(true); | ||
| const [searchText, setSearchText] = useState(''); | ||
| const [todos, setTodos] = useState([]); | ||
| const [mode, setMode] = useState('create'); |
There was a problem hiding this comment.
mode 是不是可以給三種情境
const modalMode = {
closed: 0,
create: 1,
edit: 2,
};然後 modalOpened 就不需要了?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.