fix: ComplianceBadge fallback, distribution auto-refresh, dual-path docs, engines field - #342
Merged
Conversation
…ocs, engines field - fix(compliance): guard STYLES lookup with ?? STYLES['None'] so unknown runtime status strings (e.g. via the as-never cast in AllowlistRow) degrade to a neutral badge instead of crashing. Closes RWA-ToolKit#315 - test(compliance): add test asserting ComplianceBadge renders the neutral 'Not Registered' fallback for a status value outside the known union. Closes RWA-ToolKit#316 - feat(distribution): add 30-second auto-refresh and staleness indicator to ExistingDistributionsCard. Background refreshes show a spinner; a footer displays 'Updated Xs ago · auto-refreshes every 30 s' and a manual Refresh button so issuers always know whether the claimed percentage is current. Closes RWA-ToolKit#318 - docs: document the indexer API fast-path vs Soroban RPC fallback strategy in README (new subsection with decision tree, per-hook table, and debugging tip) and add inline JSDoc to useAssets, useHolders, useHolderTotals. Closes RWA-ToolKit#319 - chore: add engines field to package.json (node >=20.0.0, npm >=10.0.0) matching the Node 20 pin in CI so npm warns locally on unsupported toolchains
|
@ofodumchristopher32-web Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(compliance): guard STYLES lookup with ?? STYLES['None'] so unknown runtime status strings (e.g. via the as-never cast in AllowlistRow) degrade to a neutral badge instead of crashing. Closes docs: document the difference between the API-backed and on-chain-fallback data paths #315
test(compliance): add test asserting ComplianceBadge renders the neutral 'Not Registered' fallback for a status value outside the known union. Closes fix: ExistingDistributionsCard's percent-claimed math ignores in-flight (unconfirmed) claims #316
feat(distribution): add 30-second auto-refresh and staleness indicator to ExistingDistributionsCard. Background refreshes show a spinner; a footer displays 'Updated Xs ago · auto-refreshes every 30 s' and a manual Refresh button so issuers always know whether the claimed percentage is current. Closes test: add coverage for ComplianceBadge with an unrecognized/unknown status value #318
docs: document the indexer API fast-path vs Soroban RPC fallback strategy in README (new subsection with decision tree, per-hook table, and debugging tip) and add inline JSDoc to useAssets, useHolders, useHolderTotals. Closes chore: audit and document required Node/npm engine versions in package.json #319
chore: add engines field to package.json (node >=20.0.0, npm >=10.0.0) matching the Node 20 pin in CI so npm warns locally on unsupported toolchains