fix(issuer): token parse validation tests, jurisdiction race, progress bar clamp, admin role docs - #341
Merged
valoryyaa-byte merged 1 commit intoAug 31, 2026
Conversation
oche2920
commented
Aug 30, 2026
- Add TokenPanel MintCard tests for parseTokenAmount validation errors (excess decimals, decimals=0, invalid input) closes docs: document the issuer panel tab structure (Token/Compliance/Distributions) and required on-chain roles #310
- Fix JurisdictionCard race: disable both block/unblock forms while either tx is in flight via shared eitherPending flag closes test: add coverage for DistributionPanel's percent-claimed progress bar edge cases #312
- Clamp DistributionPanel progress bar width to [0,100]% at render site; add ExistingDistributionsCard tests incl. out-of-range pct closes fix: CompliancePanel jurisdiction block/unblock forms don't disable their counterpart while one is pending #313
- Document required on-chain admin roles and non-admin failure behaviour for all three issuer tabs in README and CONTRIBUTING closes test: add coverage for the mint form's max-supply / decimals interaction in TokenPanel #314
…s bar clamp, admin role docs - Add TokenPanel MintCard tests for parseTokenAmount validation errors (excess decimals, decimals=0, invalid input) closes RWA-ToolKit#310 - Fix JurisdictionCard race: disable both block/unblock forms while either tx is in flight via shared eitherPending flag closes RWA-ToolKit#312 - Clamp DistributionPanel progress bar width to [0,100]% at render site; add ExistingDistributionsCard tests incl. out-of-range pct closes RWA-ToolKit#313 - Document required on-chain admin roles and non-admin failure behaviour for all three issuer tabs in README and CONTRIBUTING closes RWA-ToolKit#314
|
@oche2920 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.