Chore/nvmrc precommit component guide home route coverage - #327
Merged
valoryyaa-byte merged 4 commits intoAug 31, 2026
Conversation
…ess states and accessibility (RWA-ToolKit#240)
…works, stats-failure degradation) (RWA-ToolKit#244)
|
@Tukura11 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pins the Node version via
.nvmrcand has CI read from it instead of a separately-hardcoded value, adds atypecheck/lintpre-commit hook socontributors get the same feedback CI already enforces before pushing, writes a component-authoring guide documenting this codebase's real (not
idealized) pattern for handling loading/empty/error/success states and accessibility, and adds route-level test coverage for
/including itsstats-read failure degradation path.
Changes
#242 — repo: pin the Node version via .nvmrc and use it in CI
.nvmrcadded at repo root pinning Node 20, matching CI's hardcoded version.github/workflows/web.ymlupdated to readnode-version-file: '.nvmrc'instead of separate hardcoded valuepackage.jsonenginesfield already consistent (no changes needed)README.mdupdated with Node version setup section andnvm useguidance#243 — repo: add typecheck and lint as a pre-commit hook
huskyandlint-stagedadded as dev dependenciespackage.jsonpreparescript added to install husky hooks onnpm install.husky/pre-commithook created runningnpm run typecheck(whole codebase) thennpx lint-staged(staged files only).lintstagedrc.jsonconfigured to lint staged*.{js,jsx,ts,tsx}files vianext lint --fixREADME.mdupdated with pre-commit hook documentation and skip guidance#240 — docs: add a component-authoring guide covering states and accessibility
docs/component-authoring.mdcreated documenting this codebase's real, working pattern for the four-state lifecycle (loading, empty, error,success)
CardSkeletonGrid,Skeleton,ErrorState,EmptyState,TxProgress)role="alert"witharia-live="assertive"for errors,role="status"witharia-live="polite"for loading/success,aria-labelfor icon-only buttons, semantic headings, navigationaria-label, andaria-current="page"for pagination
README.mdlinked to the guide under a new "Component Authoring" section#244 — test: add route-level coverage for
/(home route)app/__tests__/page.test.tsxcreated with comprehensive coverageCTA) still render
jest.mock()on hooks and components; no shared contracts.ts mock utility added since existing tests mock at hooklevel
Notes
.nvmrc(new),.github/workflows/web.yml,.husky/(new),package.json(dev deps + scripts only),README.md,docs/(new), andapp/__tests__/page.test.tsx(new)/#244 testing: real degradation behavior confirmed — when contract reads fail, components render ErrorState; page structure remains intact. Nounhandled promise rejections found
FeaturedAssets, TxProgress); no components found missing states that would require separate audit
Closes #242, Closes #243, Closes #240, Closes #244