Test/format utils portfolio route coverage - #326
Merged
valoryyaa-byte merged 4 commits intoAug 31, 2026
Merged
Conversation
|
@Almikefred Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds test coverage for three pure
lib/format.tsutility functions —parseTokenAmount's accept/reject boundaries,formatRawPlain's exact round-trip behavior againstparseTokenAmount(includingtrailing-zero handling), and
compactNumber's K/M/B threshold behavior with explicit confirmation of the sub-1,000,000 non-compaction rule — plus route-level coverage for/portfolio's connect-promptand holdings-list states.
Changes
#250 — test: add coverage for parseTokenAmount
#251 — test: add coverage for formatRawPlain
parseTokenAmountconfirmed exact for representative values, with explicit trailing-zero handling tested per the real implementation's actual normalization behavior.#252 — test: add coverage for compactNumber
#249 — test: add route-level coverage for /portfolio
Notes
lib/contracts.tsmock helper from prior route-coverage work was found in this repo; existing test mocking patterns in components were reused for portfolio page tests.Closes #250, Closes #251, Closes #252, Closes #249