Repository navigation
fix(ci): restore fork validation on GitHub runners - #49
Conversation
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: unavailable · PR result: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
|
@coderabbitai full review |
|
GitHub-hosted runner allocation is confirmed. The first run started jobs within seconds, and Ubuntu/macOS jobs executed normally. Passed: Rust, Release Smoke, Mobile Native Static Analysis, Mobile Native Changes, and Native fingerprint diff. All thread-transfer ceilings passed. The first full execution exposed existing baseline failures outside the workflow-only diff:
The three server shards passed 4,667 tests, failed 5, and skipped 10. The non-server task aborted after the SSH package failed, so it did not complete every package. Check stopped at Knip before lint/typecheck/build. No checks were disabled or converted to warnings. Baseline repair scope is pending maintainer direction. |
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (31)
💤 Files with no reviewable changes (4)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe pull request moves CI jobs to GitHub-hosted runners, updates CLI commands for the scoped package registry, migrates Codex filesystem access to Effect services, narrows internal exports, and updates tests, documentation, and tooling metadata. ChangesCI, registry, and runtime cleanup
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~25 minutes Suggested reviewers: Merge Risk: ⚪ Minimal · up to The CI migration and associated validation repairs are complete, with hosted checks passing and no remaining merge-blocking risk identified. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 8.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 12 functions across 21 files. (6 skipped: 6 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai full review Please review current head The final scope restores fork validation on GitHub-hosted runners and fixes failures exposed by those runs. Full CI is green: https://github.com/RTVision/t3code/actions/runs/34547138983. Test commands and failure gates remain enabled. Fable 5.1 reviewed the earlier repairs and the Effect follow-up without verified findings. The last commit fixes a test teardown race by clearing scheduled worker animation frames before removing the test's browser globals, using the neighboring fileEditorHighlight fixture's cleanup pattern. Both focused fixture suites passed. |
🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
printf '%s\n' '== Current commit =='
git rev-parse HEAD
git status --short
printf '%s\n' '== PR base and commits =='
git merge-base HEAD origin/main 2>/dev/null || true
git log --oneline --decorate --no-merges "$(git merge-base HEAD origin/main 2>/dev/null || git rev-list --max-parents=0 HEAD)"..HEAD
printf '%s\n' '== Changed files =='
git diff --name-status "$(git merge-base HEAD origin/main 2>/dev/null || git rev-list --max-parents=0 HEAD)" HEAD
printf '%s\n' '== Diff stat =='
git diff --stat "$(git merge-base HEAD origin/main 2>/dev/null || git rev-list --max-parents=0 HEAD)" HEAD
printf '%s\n' '== Changed workflow files =='
git diff --name-only "$(git merge-base HEAD origin/main 2>/dev/null || git rev-list --max-parents=0 HEAD)" HEAD | rg '(^|/)\.github/workflows/|\.ya?ml$' || trueLength of output: 42249 🏁 Script executed: #!/bin/bash
set -euo pipefail
printf '%s\n' '== Pull request metadata =='
gh pr view 49 --repo RTVision/t3code --json number,title,baseRefName,baseRefOid,headRefName,headRefOid,mergeStateStatus,reviewDecision,statusCheckRollup,url
printf '%s\n' '== Pull request changed files =='
gh pr view 49 --repo RTVision/t3code --json files --jq '.files[] | [.path, .additions, .deletions] | `@tsv`'
printf '%s\n' '== Focused CI-repair commit diff stat =='
git diff --stat 46ec3856^..HEAD
printf '%s\n' '== Focused CI-repair changed files =='
git diff --name-status 46ec3856^..HEAD
printf '%s\n' '== Focused workflow diff =='
git diff --find-renames --unified=80 46ec3856^..HEAD -- \
.github/workflows/ci.yml \
.github/workflows/mobile-fingerprint-check.yml \
.github/workflows/release.yml \
.github/workflows/windows-tests.yml \
.github/workflows/rtvision-release.yml \
knip.jsonc
printf '%s\n' '== Focused source diff =='
git diff --find-renames --unified=60 46ec3856^..HEAD -- \
apps/server/src/provider/Layers/CodexProvider.ts \
apps/server/src/provider/Layers/CodexProvider.test.ts \
apps/server/src/provider/Layers/ProviderRegistry.ts \
apps/web/src/components/ChatMarkdown.test.tsx \
apps/web/src/components/files/fileEditorLanguageReadiness.test.ts \
apps/web/src/components/desktopUpdate.logic.ts \
apps/web/src/components/desktopUpdate.logic.test.ts \
apps/web/src/components/desktopUpdate.toast.test.tsxLength of output: 69521 🏁 Script executed: #!/bin/bash
set -euo pipefail
base='a17341af44612d566955936b4006c1428bccfc24'
printf '%s\n' '== AST outlines for changed implementation modules =='
ast-grep outline \
apps/desktop/scripts/neovim-terminal/transport.mjs \
apps/desktop/src/editors/terminalEditorRuntime.ts \
apps/desktop/src/ssh/DesktopSshEnvironment.ts \
apps/server/src/provider/Layers/CodexProvider.ts \
apps/server/src/pullRequest/GiteaForkCapabilities.ts \
apps/server/src/sourceControl/GiteaApi.ts \
apps/web/src/components/pullRequest/pullRequestDetail.logic.ts \
apps/web/src/editorPreferences.ts \
apps/web/src/remoteOpen.ts \
apps/web/src/terminalEditors.ts \
apps/web/src/vim/bindings.ts \
packages/ssh/src/tunnel.ts \
--items all
printf '%s\n' '== Exact PR diffs: implementations and test harness =='
git diff --find-renames --unified=45 "$base"..HEAD -- \
apps/desktop/scripts/neovim-terminal/transport.mjs \
apps/desktop/src/editors/terminalEditorRuntime.ts \
apps/desktop/src/ssh/DesktopSshEnvironment.ts \
apps/desktop/src/updates/updatesTestHarness.ts \
apps/server/src/pullRequest/GiteaForkCapabilities.ts \
apps/server/src/sourceControl/GiteaApi.ts \
apps/web/src/components/pullRequest/pullRequestDetail.logic.ts \
apps/web/src/editorPreferences.ts \
apps/web/src/remoteOpen.ts \
apps/web/src/terminalEditors.ts \
apps/web/src/vim/bindings.ts \
packages/ssh/src/tunnel.ts
printf '%s\n' '== Codex definitions and callers =='
rg -n -C 4 '\b(resolveCodexAuthHome|readCodexAccountId)\b' apps/server/src --glob '*.ts'
printf '%s\n' '== Modified terminal editor and editor-preference symbols: definitions and callers =='
rg -n -C 3 '\b(terminalEditors|editorPreferences|remoteOpen|pullRequestDetail)\b' \
apps/web/src apps/desktop/src --glob '*.{ts,tsx}'
printf '%s\n' '== Complete PR patch summary without test-only files =='
git diff --numstat "$base"..HEAD | awk '$3 !~ /\.test\.[^.]+$/ {print}'Length of output: 125619 🏁 Script executed: #!/bin/bash
set -euo pipefail
base='a17341af44612d566955936b4006c1428bccfc24'
printf '%s\n' '== Remaining exact PR patches =='
git diff --unified=35 "$base"..HEAD -- \
.github/triage/PLAYBOOK.md \
apps/server/src/cli/pair.test.ts \
apps/server/src/cli/serviceUpdate.test.ts \
apps/server/src/pullRequest/ActionsCi.test.ts \
apps/server/src/pullRequest/GitHubPullRequestCli.test.ts \
apps/server/src/serverRuntimeState.test.ts \
apps/server/src/sourceControl/GitLabCli.test.ts \
apps/server/src/terminal/BunPtyAdapter.test.ts \
apps/web/src/components/desktopUpdate.toast.test.tsx \
apps/web/src/components/files/fileEditorLanguageReadiness.test.ts \
apps/web/src/components/sidebar/SidebarUpdateReleaseNotes.test.tsx \
packages/ssh/src/runnerProcess.test.ts
printf '%s\n' '== Removed export references outside their defining modules =='
rg -n -C 2 '\b(validateRequest|classifyProbeFailure|giteaHasFeature|describePullRequestState|isStackedPullRequestBase|usePreferredEditor|resolvePreferredEditor|useRemoteOpenState|VIM_COMMANDS|commandAvailable|DEFAULT_REMOTE_PORT|normalizeSshErrorMessage|REMOTE_WAIT_READY_SCRIPT|REMOTE_NODE_ENV_SCRIPT|REMOTE_RUNNER_SCRIPT|REMOTE_LAUNCH_SCRIPT|REMOTE_PAIRING_SCRIPT|REMOTE_STOP_SCRIPT|stopRemoteServer)\b' \
--glob '!apps/desktop/scripts/neovim-terminal/transport.mjs' \
--glob '!apps/desktop/src/editors/terminalEditorRuntime.ts' \
--glob '!apps/server/src/pullRequest/GiteaForkCapabilities.ts' \
--glob '!apps/web/src/components/pullRequest/pullRequestDetail.logic.ts' \
--glob '!apps/web/src/editorPreferences.ts' \
--glob '!apps/web/src/remoteOpen.ts' \
--glob '!apps/web/src/vim/bindings.ts' \
--glob '!packages/ssh/src/tunnel.ts' \
. || true
printf '%s\n' '== Changed-line locations =='
git diff --unified=0 "$base"..HEAD -- \
.github/workflows/ci.yml \
apps/server/src/provider/Layers/CodexProvider.ts \
apps/web/src/components/files/fileEditorLanguageReadiness.test.ts \
apps/web/src/terminalEditors.tsLength of output: 77363
I found no actionable findings. I verified the PR comparison against the GitHub reports all applicable CI checks as successful at this head. ✅ Action performedFull review finished. |
The fork's validation workflows wait indefinitely for unavailable Blacksmith runners. Switching to GitHub-hosted runners immediately started the jobs and exposed validation regressions left by earlier fork changes.
Use Ubuntu 24.04, macOS 26, and Windows 2025 for CI, mobile fingerprint checks, and the manual Windows test lane. CI now runs on pushes to
rtvision, with 30-minute limits for the smaller runners. Existing test commands, sharding, permissions, and failure behavior are preserved.Repair the failures revealed by the first full runs:
Validation:
f6dc463eb, including all test lanes, typechecks, lint, and the desktop build. No checks were disabled or converted to warnings.No visible UI changes.
Implemented with GPT-6 through Codex.
Summary by CodeRabbit
Bug Fixes
Documentation
Chores