Skip to content

fix(ci): restore fork validation on GitHub runners - #49

Merged
kalvenschraut merged 6 commits into
rtvisionfrom
fix/github-hosted-ci-runners
Sep 11, 2026
Merged

kalvenschraut merged 6 commits into
rtvisionfrom
fix/github-hosted-ci-runners

Conversation

@kalvenschraut

@kalvenschraut kalvenschraut commented Sep 10, 2026 •

Copy link
Copy Markdown
Member

The fork's validation workflows wait indefinitely for unavailable Blacksmith runners. Switching to GitHub-hosted runners immediately started the jobs and exposed validation regressions left by earlier fork changes.

Use Ubuntu 24.04, macOS 26, and Windows 2025 for CI, mobile fingerprint checks, and the manual Windows test lane. CI now runs on pushes to rtvision, with 30-minute limits for the smaller runners. Existing test commands, sharding, permissions, and failure behavior are preserved.

Repair the failures revealed by the first full runs:

  • Align CLI, SSH, and release-note expectations with the shipped RTVision registry and URLs; retain GitLab timestamps in fixtures and synchronize the triage playbook.
  • Register standalone Neovim tooling with Knip, keep internal helpers private, and remove obsolete wrappers with no callers. Preserve canonical Effect service constructors as public APIs.
  • Use Effect filesystem/path services for Codex account identity reads, preserving credential-home precedence and fallback behavior. Encode JSON fixtures with Schema and use tagged errors in CI tests.
  • Cancel pending worker animation frames before removing test globals, fixing the intermittent editor fixture teardown error seen in hosted CI.
  • Supply the terminal-editor hook's server snapshot, which was missing when rendering chat messages in existing tests. Name the desktop updater fixture's feed URL type so TypeScript can describe its exported return type.

Validation:

  • GitHub assigned runners within seconds. All three server test shards passed after the fixture repairs. Rust, release smoke, mobile native analysis, fingerprint checks, and thread-transfer ceilings passed.
  • 338 focused tests passed during the earlier repairs, followed by 218 focused server tests for the Effect changes and 15 worker/editor fixture tests. Server, web, desktop, and SSH typechecks passed. Focused Knip checks, targeted lint/formatting, and actionlint 1.7.12 passed.
  • Fable 5.1 reviewed the repairs and the final Effect follow-up, with no verified findings.
  • Full hosted CI passed on f6dc463eb, including all test lanes, typechecks, lint, and the desktop build. No checks were disabled or converted to warnings.

No visible UI changes.

Implemented with GPT-6 through Codex.

Summary by CodeRabbit

  • Bug Fixes

    • Improved terminal editor rendering during server-side rendering and hydration by consistently showing a disconnected state until connected.
    • Updated desktop and sidebar release-note links to the current T3 Code repository.
  • Documentation

    • Corrected formatting in the background-service documentation.
    • Updated setup examples to use the scoped T3 package and registry.
  • Chores

    • Updated automated checks and tests to run on GitHub-hosted environments.
    • Improved test reliability and validation for service, authentication, and pull request workflows.

@github-actions github-actions Bot added vouch:trusted Author is trusted by repo permissions or the VOUCHED list. size:M labels Sep 10, 2026
@github-actions

github-actions Bot commented Sep 10, 2026 •

Copy link
Copy Markdown

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ No successful main baseline artifact is available yet. This run establishes the initial measurement.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire — 13.6 KiB — 15.1 KiB ✅
Codex Thread snapshot wire — 7.0 KiB — 7.3 KiB ✅
Codex Live turn WebSocket wire — 6.6 KiB — 7.8 KiB ✅
Codex Live turn WebSocket decoded — 57.1 KiB — 66.4 KiB ✅
Codex Live turn messages — 10 — 21 ✅
Claude Total thread wire — 13.6 KiB — 15.1 KiB ✅
Claude Thread snapshot wire — 7.0 KiB — 7.3 KiB ✅
Claude Live turn WebSocket wire — 6.5 KiB — 7.8 KiB ✅
Claude Live turn WebSocket decoded — 57.8 KiB — 66.4 KiB ✅
Claude Live turn messages — 9 — 21 ✅

Baseline: unavailable · PR result: f6dc463 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 113.9 KiB
  • Claude decoded thread snapshot: 114.6 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@kalvenschraut

Copy link
Copy Markdown
Member Author

@coderabbitai full review

@kalvenschraut

Copy link
Copy Markdown
Member Author

GitHub-hosted runner allocation is confirmed. The first run started jobs within seconds, and Ubuntu/macOS jobs executed normally.

Passed: Rust, Release Smoke, Mobile Native Static Analysis, Mobile Native Changes, and Native fingerprint diff. All thread-transfer ceilings passed.

The first full execution exposed existing baseline failures outside the workflow-only diff:

  • Knip flags apps/desktop/scripts/neovim-terminal/spike.mjs and transport.d.mts.
  • packages/ssh/src/runnerProcess.test.ts: 14 failed assertions involving RTVision registry arguments and existing CLI fixtures.
  • apps/server/src/sourceControl/GitLabCli.test.ts: 2 expectations omit fields now returned by the adapter.
  • apps/server/src/cli/triagePrompt.test.ts: embedded prompt differs from the playbook.
  • apps/server/src/cli/pair.test.ts and apps/server/src/terminal/BunPtyAdapter.test.ts: expected guidance still names the upstream package.

The three server shards passed 4,667 tests, failed 5, and skipped 10. The non-server task aborted after the SSH package failed, so it did not complete every package. Check stopped at Knip before lint/typecheck/build.

No checks were disabled or converted to warnings. Baseline repair scope is pending maintainer direction.

@coderabbitai

coderabbitai Bot commented Sep 10, 2026 •

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.


Your included review limit is currently reached under our Fair Usage Limits Policy. This review may still proceed through usage-based billing if eligible. Your next included review will be available in 54 minutes.

@coderabbitai

coderabbitai Bot commented Sep 10, 2026 •

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: ef998f17-dddf-434a-90d2-1dfe6e0f1cf5

📥 Commits

Reviewing files that changed from the base of the PR and between a17341a and f6dc463.

📒 Files selected for processing (31)
  • .github/triage/PLAYBOOK.md
  • .github/workflows/ci.yml
  • .github/workflows/mobile-fingerprint-check.yml
  • .github/workflows/windows-tests.yml
  • apps/desktop/scripts/neovim-terminal/transport.mjs
  • apps/desktop/src/editors/terminalEditorRuntime.ts
  • apps/desktop/src/ssh/DesktopSshEnvironment.ts
  • apps/desktop/src/updates/updatesTestHarness.ts
  • apps/server/src/cli/pair.test.ts
  • apps/server/src/cli/serviceUpdate.test.ts
  • apps/server/src/provider/Layers/CodexProvider.test.ts
  • apps/server/src/provider/Layers/CodexProvider.ts
  • apps/server/src/pullRequest/ActionsCi.test.ts
  • apps/server/src/pullRequest/GitHubPullRequestCli.test.ts
  • apps/server/src/pullRequest/GiteaForkCapabilities.ts
  • apps/server/src/serverRuntimeState.test.ts
  • apps/server/src/sourceControl/GitLabCli.test.ts
  • apps/server/src/sourceControl/GiteaApi.ts
  • apps/server/src/terminal/BunPtyAdapter.test.ts
  • apps/web/src/components/desktopUpdate.toast.test.tsx
  • apps/web/src/components/files/fileEditorLanguageReadiness.test.ts
  • apps/web/src/components/pullRequest/pullRequestDetail.logic.ts
  • apps/web/src/components/sidebar/SidebarUpdateReleaseNotes.test.tsx
  • apps/web/src/editorPreferences.ts
  • apps/web/src/remoteOpen.ts
  • apps/web/src/terminalEditors.ts
  • apps/web/src/vim/bindings.ts
  • docs/user/background-service.md
  • knip.jsonc
  • packages/ssh/src/runnerProcess.test.ts
  • packages/ssh/src/tunnel.ts
💤 Files with no reviewable changes (4)
  • apps/web/src/remoteOpen.ts
  • apps/server/src/pullRequest/GiteaForkCapabilities.ts
  • apps/web/src/components/pullRequest/pullRequestDetail.logic.ts
  • apps/web/src/editorPreferences.ts

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The pull request moves CI jobs to GitHub-hosted runners, updates CLI commands for the scoped package registry, migrates Codex filesystem access to Effect services, narrows internal exports, and updates tests, documentation, and tooling metadata.

Changes

CI, registry, and runtime cleanup

Layer / File(s) Summary
CI runners and registry-qualified CLI flows
.github/workflows/*, .github/triage/PLAYBOOK.md, apps/server/src/cli/pair.test.ts, apps/server/src/terminal/BunPtyAdapter.test.ts, packages/ssh/src/runnerProcess.test.ts
CI uses GitHub-hosted runners and also triggers on rtvision. CLI examples and test expectations use @rtvision/t3 with the configured registry.
Effect service integration and typed test fixtures
apps/server/src/provider/Layers/*, apps/server/src/cli/serviceUpdate.test.ts, apps/server/src/serverRuntimeState.test.ts, apps/server/src/pullRequest/*test.ts
Codex account probing uses injected Effect filesystem and path services. Test fixtures use schema-based JSON encoding, scoped temporary directories, and tagged errors.
Internal API and runtime surface cleanup
apps/desktop/scripts/neovim-terminal/transport.mjs, apps/desktop/src/*, apps/server/src/pullRequest/GiteaForkCapabilities.ts, apps/web/src/editorPreferences.ts, apps/web/src/remoteOpen.ts, apps/web/src/vim/bindings.ts, packages/ssh/src/tunnel.ts, knip.jsonc
Unused exports are made module-private or removed. Terminal editor hydration now provides a disconnected server snapshot. Related service documentation and tooling entries are updated.
Test isolation and repository URL expectations
apps/web/src/components/*test.*, apps/server/src/sourceControl/GitLabCli.test.ts, docs/user/background-service.md
Web tests clear pending animation frames. Release-note expectations use the RTVision/t3code repository, and GitLab expectations include explicit null timestamps.

Priority: ➖ Normal

Estimated code review effort: 3 (Moderate) | ~25 minutes

Suggested reviewers: juliusmarminge, t3dotgg

Merge Risk: ⚪ Minimal · up to f6dc4

The CI migration and associated validation repairs are complete, with hosted checks passing and no remaining merge-blocking risk identified.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 8.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 12 functions across 21 files. (6 skipped: … Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the primary change: restoring fork validation on GitHub-hosted runners.
Description check ✅ Passed The description explains what changed, why it changed, validation results, and the absence of UI changes. It omits the template headings and checklist, but the required information is mostly present.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 8.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 12 functions across 21 files. (6 skipped: 6 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/github-hosted-ci-runners

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kalvenschraut kalvenschraut changed the title fix(ci): use GitHub-hosted validation runners fix(ci): restore fork validation on GitHub runners Sep 10, 2026
@github-actions github-actions Bot added size:L and removed size:M labels Sep 11, 2026
@kalvenschraut

Copy link
Copy Markdown
Member Author

@coderabbitai full review

Please review current head f6dc463eb43206bb13e48e26e57960ebc3718598. The earlier request was rate limited before any review ran.

The final scope restores fork validation on GitHub-hosted runners and fixes failures exposed by those runs. Full CI is green: https://github.com/RTVision/t3code/actions/runs/34547138983. Test commands and failure gates remain enabled. Fable 5.1 reviewed the earlier repairs and the Effect follow-up without verified findings.

The last commit fixes a test teardown race by clearing scheduled worker animation frames before removing the test's browser globals, using the neighboring fileEditorHighlight fixture's cleanup pattern. Both focused fixture suites passed.

@coderabbitai

coderabbitai Bot commented Sep 11, 2026 •

Copy link
Copy Markdown
🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

printf '%s\n' '== Current commit =='
git rev-parse HEAD
git status --short
printf '%s\n' '== PR base and commits =='
git merge-base HEAD origin/main 2>/dev/null || true
git log --oneline --decorate --no-merges "$(git merge-base HEAD origin/main 2>/dev/null || git rev-list --max-parents=0 HEAD)"..HEAD
printf '%s\n' '== Changed files =='
git diff --name-status "$(git merge-base HEAD origin/main 2>/dev/null || git rev-list --max-parents=0 HEAD)" HEAD
printf '%s\n' '== Diff stat =='
git diff --stat "$(git merge-base HEAD origin/main 2>/dev/null || git rev-list --max-parents=0 HEAD)" HEAD
printf '%s\n' '== Changed workflow files =='
git diff --name-only "$(git merge-base HEAD origin/main 2>/dev/null || git rev-list --max-parents=0 HEAD)" HEAD | rg '(^|/)\.github/workflows/|\.ya?ml$' || true

Length of output: 42249


🏁 Script executed:

#!/bin/bash
set -euo pipefail

printf '%s\n' '== Pull request metadata =='
gh pr view 49 --repo RTVision/t3code --json number,title,baseRefName,baseRefOid,headRefName,headRefOid,mergeStateStatus,reviewDecision,statusCheckRollup,url

printf '%s\n' '== Pull request changed files =='
gh pr view 49 --repo RTVision/t3code --json files --jq '.files[] | [.path, .additions, .deletions] | `@tsv`'

printf '%s\n' '== Focused CI-repair commit diff stat =='
git diff --stat 46ec3856^..HEAD

printf '%s\n' '== Focused CI-repair changed files =='
git diff --name-status 46ec3856^..HEAD

printf '%s\n' '== Focused workflow diff =='
git diff --find-renames --unified=80 46ec3856^..HEAD -- \
  .github/workflows/ci.yml \
  .github/workflows/mobile-fingerprint-check.yml \
  .github/workflows/release.yml \
  .github/workflows/windows-tests.yml \
  .github/workflows/rtvision-release.yml \
  knip.jsonc

printf '%s\n' '== Focused source diff =='
git diff --find-renames --unified=60 46ec3856^..HEAD -- \
  apps/server/src/provider/Layers/CodexProvider.ts \
  apps/server/src/provider/Layers/CodexProvider.test.ts \
  apps/server/src/provider/Layers/ProviderRegistry.ts \
  apps/web/src/components/ChatMarkdown.test.tsx \
  apps/web/src/components/files/fileEditorLanguageReadiness.test.ts \
  apps/web/src/components/desktopUpdate.logic.ts \
  apps/web/src/components/desktopUpdate.logic.test.ts \
  apps/web/src/components/desktopUpdate.toast.test.tsx

Length of output: 69521


🏁 Script executed:

#!/bin/bash
set -euo pipefail

base='a17341af44612d566955936b4006c1428bccfc24'

printf '%s\n' '== AST outlines for changed implementation modules =='
ast-grep outline \
  apps/desktop/scripts/neovim-terminal/transport.mjs \
  apps/desktop/src/editors/terminalEditorRuntime.ts \
  apps/desktop/src/ssh/DesktopSshEnvironment.ts \
  apps/server/src/provider/Layers/CodexProvider.ts \
  apps/server/src/pullRequest/GiteaForkCapabilities.ts \
  apps/server/src/sourceControl/GiteaApi.ts \
  apps/web/src/components/pullRequest/pullRequestDetail.logic.ts \
  apps/web/src/editorPreferences.ts \
  apps/web/src/remoteOpen.ts \
  apps/web/src/terminalEditors.ts \
  apps/web/src/vim/bindings.ts \
  packages/ssh/src/tunnel.ts \
  --items all

printf '%s\n' '== Exact PR diffs: implementations and test harness =='
git diff --find-renames --unified=45 "$base"..HEAD -- \
  apps/desktop/scripts/neovim-terminal/transport.mjs \
  apps/desktop/src/editors/terminalEditorRuntime.ts \
  apps/desktop/src/ssh/DesktopSshEnvironment.ts \
  apps/desktop/src/updates/updatesTestHarness.ts \
  apps/server/src/pullRequest/GiteaForkCapabilities.ts \
  apps/server/src/sourceControl/GiteaApi.ts \
  apps/web/src/components/pullRequest/pullRequestDetail.logic.ts \
  apps/web/src/editorPreferences.ts \
  apps/web/src/remoteOpen.ts \
  apps/web/src/terminalEditors.ts \
  apps/web/src/vim/bindings.ts \
  packages/ssh/src/tunnel.ts

printf '%s\n' '== Codex definitions and callers =='
rg -n -C 4 '\b(resolveCodexAuthHome|readCodexAccountId)\b' apps/server/src --glob '*.ts'

printf '%s\n' '== Modified terminal editor and editor-preference symbols: definitions and callers =='
rg -n -C 3 '\b(terminalEditors|editorPreferences|remoteOpen|pullRequestDetail)\b' \
  apps/web/src apps/desktop/src --glob '*.{ts,tsx}'

printf '%s\n' '== Complete PR patch summary without test-only files =='
git diff --numstat "$base"..HEAD | awk '$3 !~ /\.test\.[^.]+$/ {print}'

Length of output: 125619


🏁 Script executed:

#!/bin/bash
set -euo pipefail

base='a17341af44612d566955936b4006c1428bccfc24'

printf '%s\n' '== Remaining exact PR patches =='
git diff --unified=35 "$base"..HEAD -- \
  .github/triage/PLAYBOOK.md \
  apps/server/src/cli/pair.test.ts \
  apps/server/src/cli/serviceUpdate.test.ts \
  apps/server/src/pullRequest/ActionsCi.test.ts \
  apps/server/src/pullRequest/GitHubPullRequestCli.test.ts \
  apps/server/src/serverRuntimeState.test.ts \
  apps/server/src/sourceControl/GitLabCli.test.ts \
  apps/server/src/terminal/BunPtyAdapter.test.ts \
  apps/web/src/components/desktopUpdate.toast.test.tsx \
  apps/web/src/components/files/fileEditorLanguageReadiness.test.ts \
  apps/web/src/components/sidebar/SidebarUpdateReleaseNotes.test.tsx \
  packages/ssh/src/runnerProcess.test.ts

printf '%s\n' '== Removed export references outside their defining modules =='
rg -n -C 2 '\b(validateRequest|classifyProbeFailure|giteaHasFeature|describePullRequestState|isStackedPullRequestBase|usePreferredEditor|resolvePreferredEditor|useRemoteOpenState|VIM_COMMANDS|commandAvailable|DEFAULT_REMOTE_PORT|normalizeSshErrorMessage|REMOTE_WAIT_READY_SCRIPT|REMOTE_NODE_ENV_SCRIPT|REMOTE_RUNNER_SCRIPT|REMOTE_LAUNCH_SCRIPT|REMOTE_PAIRING_SCRIPT|REMOTE_STOP_SCRIPT|stopRemoteServer)\b' \
  --glob '!apps/desktop/scripts/neovim-terminal/transport.mjs' \
  --glob '!apps/desktop/src/editors/terminalEditorRuntime.ts' \
  --glob '!apps/server/src/pullRequest/GiteaForkCapabilities.ts' \
  --glob '!apps/web/src/components/pullRequest/pullRequestDetail.logic.ts' \
  --glob '!apps/web/src/editorPreferences.ts' \
  --glob '!apps/web/src/remoteOpen.ts' \
  --glob '!apps/web/src/vim/bindings.ts' \
  --glob '!packages/ssh/src/tunnel.ts' \
  . || true

printf '%s\n' '== Changed-line locations =='
git diff --unified=0 "$base"..HEAD -- \
  .github/workflows/ci.yml \
  apps/server/src/provider/Layers/CodexProvider.ts \
  apps/web/src/components/files/fileEditorLanguageReadiness.test.ts \
  apps/web/src/terminalEditors.ts

Length of output: 77363


@kalvenschraut Full review complete for #49 at f6dc463eb43206bb13e48e26e57960ebc3718598.

I found no actionable findings.

I verified the PR comparison against the rtvision base branch. The workflow changes retain the job structure and failure gates while using GitHub-hosted runners. The Effect filesystem and path updates preserve the Codex credential-home precedence. The fixture cleanup cancels queued animation frames before test globals are removed. The removed helper exports have no remaining callers.

GitHub reports all applicable CI checks as successful at this head.

✅ Action performed

Full review finished.

@kalvenschraut
kalvenschraut merged commit 1f8050e into rtvision Sep 11, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L vouch:trusted Author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant