Repository navigation
fix(desktop): allow Neovim console access on older WSL - #48
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening Neovim through the Windows desktop app can fail before SSH starts with
Wsl/Service/E_ACCESSDENIEDon WSL 2.2.4. The standalone helper opensCONIN$read-only; an otherwise identical helper with read/write access passed the affected machine's comparison test.Open the interactive console handle with
r+. PowerShell remains the outer launcher, and WSL distro/account selection, home-directory SSH credentials, and interactive passphrase authentication are preserved. Add a Windows regression test that allocates a private console and verifies the child receives both read and write access.Validation:
rtvisionbase: 31 focused tests passed across transport, editor runtime, IPC routing, and SSH runner; targeted lint, formatting, and diff checks passed.node:testregistration adapter, and failed against the original read-only helper.~/.ssh/id_ed25519, no agent, both passphrase prompts, and a saved keyboard edit.Independent Astra review: GO, no blocking correctness findings at
4a343bc49615e440a7343c79bd1b1d14ad4e084d. The reviewer inspected the full diff and surrounding launch/test code; it did not execute tests. The Windows Vite registration and coworker's post-install saved-environment launch remain unverified. Fable was initially attempted but was unavailable due to its account usage limit; the maintainer requested Astra instead.Implemented with GPT-6 in Codex.