Skip to content

[HUST CSE][bsp][pico_malloc.c]Modify the code to check if rc is a nul… #7573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jming912
Copy link

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

这段代码可能试图将空指针转换为 uint8_t* 类型并且尝试在这个指针的基础上进行加法操作。这种行为是未定义的,即其结果取决于具体的编译器和运行环境。在某些情况下,这可能导致程序崩溃。为了避免这种情况,最好在访问指针之前检查它是否为 NULL。

你的解决方案是什么 (what is your solution)

在这个修改后的版本中,我们首先检查 rc 是否为 NULL。如果 rc 是 NULL,我们打印一条消息说明 calloc 未能分配所需的内存。只有当 rc 不为 NULL 时,我们才会尝试进行指针运算并进行下一步的条件判断。这样就避免了在 rc 为 NULL 时进行未定义的指针运算。

在什么测试环境下测试通过 (what is the test environment)

All
]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • [√ ] 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • [√ ] 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • [√ ] 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • [√ ] 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • [√ ] 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • [√ ] 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • [√ ] 代码是高质量的 Code in this PR is of high quality
  • [√ ] 已经使用formatting等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

@mysterywolf
Copy link
Member

你好这个是第三方HAL库,请向上游提交。

@mysterywolf
Copy link
Member

#7509

@jming912
Copy link
Author

你好这个是第三方HAL库,请向上游提交。

请问怎么向上游提交呢

@mysterywolf
Copy link
Member

https://github.com/raspberrypi/pico-sdk 这个是上游的地址

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants