✨ Add new bank

Author: rsginer-stihl

src/main/kotlin/com/rsginer/hackathoon/banks/controller/BankController.kt

@@ -16,10 +16,17 @@ class BankController(
     fun handleNotFound(e: NoSuchElementException): ResponseEntity<String> =
         ResponseEntity(e.message, HttpStatus.NOT_FOUND)
 
+    @ExceptionHandler(IllegalArgumentException::class)
+    fun handleBadRequest(e: IllegalArgumentException): ResponseEntity<String> =
+        ResponseEntity(e.message, HttpStatus.BAD_REQUEST)
+
     @GetMapping
     fun getBanks(): Collection<Bank> = this.bankService.getBanks()
 
     @GetMapping("/{accountNumber}")
     fun getBankByAccountNumber(@PathVariable accountNumber: String): Bank  = this.bankService.getBank(accountNumber)
 
+    @PostMapping
+    @ResponseStatus(HttpStatus.CREATED)
+    fun addBank(@RequestBody bank: Bank): Bank = bankService.addBank(bank)
 }

src/main/kotlin/com/rsginer/hackathoon/banks/datasource/BankDataSource.kt

@@ -5,4 +5,5 @@ import com.rsginer.hackathoon.banks.model.Bank
 interface BankDataSource {
     fun retrieveBanks(): Collection<Bank>
     fun retrieveBank(accountNumber: String): Bank
+    fun createBank(bank: Bank): Bank
 }

src/main/kotlin/com/rsginer/hackathoon/banks/datasource/mock/MockBankDataSource.kt

@@ -3,11 +3,12 @@ package com.rsginer.hackathoon.banks.datasource.mock
 import com.rsginer.hackathoon.banks.datasource.BankDataSource
 import com.rsginer.hackathoon.banks.model.Bank
 import org.springframework.stereotype.Repository
+import java.lang.IllegalArgumentException
 
 @Repository
 class MockBankDataSource : BankDataSource {
 
-    private val banks = listOf(
+    private val banks = mutableListOf<Bank>(
         Bank("12345", 0.1, 1),
         Bank("10101", 0.1, 2),
         Bank("50505", 1.0, 100)
@@ -16,4 +17,15 @@ class MockBankDataSource : BankDataSource {
     override fun retrieveBanks(): Collection<Bank> = banks
     override fun retrieveBank(accountNumber: String): Bank = banks.firstOrNull() { it.accountNumber == accountNumber }
         ?: throw NoSuchElementException("Could not find a bank with accountNumber $accountNumber")
+
+    override fun createBank(bank: Bank): Bank {
+
+        if (banks.any { it.accountNumber == bank.accountNumber }) {
+            throw IllegalArgumentException("Bank with accountNumber ${bank.accountNumber} already exist")
+        }
+
+        banks.add(bank)
+
+        return bank
+    }
 }

src/main/kotlin/com/rsginer/hackathoon/banks/service/BankService.kt

@@ -12,4 +12,6 @@ class BankService(
 
     fun getBank(accountNumber: String) = dataSource.retrieveBank(accountNumber)
 
+    fun addBank(bank: Bank) = dataSource.createBank(bank)
+
 }

src/test/kotlin/com/rsginer/hackathoon/banks/controller/BankControllerTest.kt

@@ -1,5 +1,7 @@
 package com.rsginer.hackathoon.banks.controller
 
+import com.fasterxml.jackson.databind.ObjectMapper
+import com.rsginer.hackathoon.banks.model.Bank
 import org.junit.jupiter.api.Assertions.*
 import org.junit.jupiter.api.DisplayName
 import org.junit.jupiter.api.Nested
@@ -11,16 +13,17 @@ import org.springframework.boot.test.context.SpringBootTest
 import org.springframework.http.MediaType
 import org.springframework.test.web.servlet.MockMvc
 import org.springframework.test.web.servlet.get
+import org.springframework.test.web.servlet.post
 
 @SpringBootTest
 @AutoConfigureMockMvc
-internal class BankControllerTest {
-
-    @Autowired
-    lateinit var mockMvc: MockMvc
+internal class BankControllerTest @Autowired constructor(
+    val mockMvc: MockMvc,
+    val objectMapper: ObjectMapper
+) {
 
     @Nested
-    @DisplayName("getBanks()")
+    @DisplayName("GET /api/banks")
     @TestInstance(TestInstance.Lifecycle.PER_CLASS)
     inner class GetBanks {
         @Test
@@ -41,12 +44,10 @@ internal class BankControllerTest {
                     }
                 }
         }
-
-
     }
 
     @Nested
-    @DisplayName("getBank()")
+    @DisplayName("GET /api/banks/{accountNumber}")
     @TestInstance(TestInstance.Lifecycle.PER_CLASS)
     inner class GetBank {
         @Test
@@ -74,6 +75,39 @@ internal class BankControllerTest {
                 }
         }
     }
-    
+
+    @Nested
+    @DisplayName("POST /api/banks")
+    @TestInstance(TestInstance.Lifecycle.PER_CLASS)
+    inner class PostNewBank {
+
+        @Test
+        fun `should add new bank`() {
+            val newBank = Bank("54321", 34.0, 2)
+
+            mockMvc.post("/api/banks") {
+                contentType = MediaType.APPLICATION_JSON
+                content = objectMapper.writeValueAsString(newBank)
+            }
+                .andDo { print() }
+                .andExpect {
+                    status { isCreated() }
+                    jsonPath("$.accountNumber") { value("54321") }
+                    jsonPath("$.trust") { value("34.0") }
+                }
+        }
+
+        @Test
+        fun `should return BAD REQUEST if accountNumber already exist`() {
+            val invalidBank = Bank("12345", 20.0, 2)
+
+            mockMvc.post("/api/banks") {
+                contentType = MediaType.APPLICATION_JSON
+                content = objectMapper.writeValueAsString(invalidBank)
+            }
+                .andDo { print() }
+                .andExpect { status { isBadRequest() } }
+        }
+    }
 
 }