🥅 Feature handle 404 errors

Author: rsginer-stihl

src/main/kotlin/com/rsginer/hackathoon/banks/controller/BankController.kt

@@ -2,22 +2,24 @@ package com.rsginer.hackathoon.banks.controller
 
 import com.rsginer.hackathoon.banks.model.Bank
 import com.rsginer.hackathoon.banks.service.BankService
-import org.springframework.web.bind.annotation.GetMapping
-import org.springframework.web.bind.annotation.PathVariable
-import org.springframework.web.bind.annotation.RequestMapping
-import org.springframework.web.bind.annotation.RestController
+import org.springframework.http.HttpStatus
+import org.springframework.http.ResponseEntity
+import org.springframework.web.bind.annotation.*
 
 @RestController
 @RequestMapping("api/banks")
 class BankController(
     private val bankService: BankService
 ) {
 
+    @ExceptionHandler(NoSuchElementException::class)
+    fun handleNotFound(e: NoSuchElementException): ResponseEntity<String> =
+        ResponseEntity(e.message, HttpStatus.NOT_FOUND)
+
     @GetMapping
     fun getBanks(): Collection<Bank> = this.bankService.getBanks()
 
     @GetMapping("/{accountNumber}")
-    fun getBankByAccountNumber(@PathVariable accountNumber: String): Bank {
-        return this.bankService.getBank(accountNumber)
-    }
+    fun getBankByAccountNumber(@PathVariable accountNumber: String): Bank  = this.bankService.getBank(accountNumber)
+
 }

src/main/kotlin/com/rsginer/hackathoon/banks/datasource/mock/MockBankDataSource.kt

@@ -14,5 +14,6 @@ class MockBankDataSource : BankDataSource {
     )
 
     override fun retrieveBanks(): Collection<Bank> = banks
-    override fun retrieveBank(accountNumber: String): Bank = banks.first { it.accountNumber == accountNumber }
+    override fun retrieveBank(accountNumber: String): Bank = banks.firstOrNull() { it.accountNumber == accountNumber }
+        ?: throw NoSuchElementException("Could not find a bank with accountNumber $accountNumber")
 }

src/test/kotlin/com/rsginer/hackathoon/banks/controller/BankControllerTest.kt

@@ -71,7 +71,6 @@ internal class BankControllerTest {
                 .andDo { print() }
                 .andExpect {
                     status { isNotFound() }
-                    content { contentType(MediaType.APPLICATION_JSON) }
                 }
         }
     }