Skip to content

Return ASCOM INVALID_VALUE for out-of-range integer parameters #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ivonnyssen wants to merge 6 commits into
base: main
Choose a base branch
from
+348 −29
Open

Return ASCOM INVALID_VALUE for out-of-range integer parameters #14

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c6f1bad
return InvalidValue if usize index gets a negative value
ivonnyssen Jan 19, 2026
952f527
Custom deserialier now treats invalid integers as OK, with ASCOM Error
ivonnyssen Jan 20, 2026
327b980
Widen integer parsing from i32 to i64 to support uint32 parameters
claude Apr 6, 2026
28bba71
Rename ALPACA to Alpaca in params.rs
ivonnyssen Apr 21, 2026
73a3bb8
Merge ParameterOutOfRange into BadParameter
ivonnyssen Apr 21, 2026
234c4a2
Drop serde_plain dependency
ivonnyssen Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/server/error.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,12 @@ pub(crate) enum Error {
#[source]
err: serde_plain::Error,
},
#[error("Parameter {name:?} value {value} is out of range for {target_type}")]
ParameterOutOfRange {
Comment thread
ivonnyssen marked this conversation as resolved.
Outdated
name: &'static str,
value: i64,
target_type: &'static str,
},
#[error(transparent)]
Ascom(#[from] ASCOMError),
}
Expand All @@ -32,7 +38,9 @@ impl IntoResponse for Error {
fn into_response(self) -> Response {
let code = match self {
Self::UnknownDeviceNumber { .. } | Self::UnknownAction { .. } => StatusCode::NOT_FOUND,
Self::MissingParameter { .. } | Self::BadParameter { .. } => StatusCode::BAD_REQUEST,
Self::MissingParameter { .. }
| Self::BadParameter { .. }
| Self::ParameterOutOfRange { .. } => StatusCode::BAD_REQUEST,
Self::Ascom(_) => StatusCode::INTERNAL_SERVER_ERROR,
};
(code, format!("{self:#}")).into_response()
Comment on lines 32 to 39
Expand Down
Loading
Loading