Fix for partial commits in Edit Table #5874
Merged
+41
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This case only applies for AFFIMRATIVE actions such as pressing a dialog's OK button. By cancelling the dialog close, we give the user a chance to correct and validation errors. Fixes the **Add Resource** and **Edit Token** dialogs that have both been changed to better leverage the GenericDialog, but as a result suffered from closing upon validation errors.
The parsing (and thus validation) of the entries is now done before any modifications have been applied to the underlying `LookupTable`. This way, validation errors will not result in table data being lost if the user later cancels the dialog.
Contributor
Admittedly I could wait and check once this ticket is merged but.... do you think fixing this issue will also resolve #5831? |
cwisniew
approved these changes
Nov 20, 2025
github-project-automation
bot
moved this from Awaiting-Review
to To-Be-Merged
in MapTool 1.19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Fixes #5869
Description of the Change
Changes how the New Table / Edit Table commits the entries to a
LookupTable. All entries are now parsed prior to any modification of theLookupTable, stored in a list for later consumption. Only once all validations are completed are any table properties modified or entries added.Also fixes an issue where
GenericDialogwould ignore the result ofAbeillePanel#commit(). This caused a problem where dialogs with validation errors would close themselves after the user dismissed the validation error modal. So far this has only affected the Edit Token and Add Resource dialogs in development builds. Other dialogs do not yet take full advantage ofGenericDialogand have to handle the commit failures explicitly, so they do not have this issue.Possible Drawbacks
None
Documentation Notes
N/A
Release Notes
This change is