Skip to content

ci: set RUSTFLAGS=-D warnings to fail on compiler warnings#58

Merged
shiv-tyagi merged 1 commit into
ROCm:mainfrom
sgopinath1:werror
Jun 3, 2026
Merged

ci: set RUSTFLAGS=-D warnings to fail on compiler warnings#58
shiv-tyagi merged 1 commit into
ROCm:mainfrom
sgopinath1:werror

Conversation

@sgopinath1

Copy link
Copy Markdown
Collaborator

Report warnings as errors.

Copilot AI review requested due to automatic review settings June 3, 2026 06:09

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the GitHub Actions CI workflow to treat Rust compiler warnings as errors, ensuring new warnings fail CI and don’t silently accumulate in the codebase.

Changes:

  • Set RUSTFLAGS=-D warnings at the workflow env level so Rust compilation in CI fails on warnings.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@shiv-tyagi
shiv-tyagi merged commit 7c09444 into ROCm:main Jun 3, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants