refactor(k8s): rename spur.ai domain prefix to spur.amd.com#57
Merged
shiv-tyagi merged 1 commit intoJun 2, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates Kubernetes API group and label/RBAC prefixes from spur.ai to spur.amd.com to align with Kubernetes best practices (using an organization-controlled domain) and match the companion rename in the Spur operator repo.
Changes:
- Renamed the SpurJob CRD API group to
spur.amd.comin the RustCustomResourcedefinition. - Updated Kubernetes label selectors/keys from
spur.ai/*tospur.amd.com/*in the API service and WebSocket pod lookup. - Updated documentation examples to use the new node label prefix.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| README.md | Updates node labeling examples to use spur.amd.com/*. |
| deploy/k8s/gpuaas-api.yaml | Updates RBAC apiGroups for SpurJob CRDs to spur.amd.com. |
| crates/spur-cloud-api/src/spur_client.rs | Updates CRD group and session/managed-by label keys to spur.amd.com/*. |
| crates/spur-cloud-api/src/routes/ws.rs | Updates pod label selector for terminal lookup to spur.amd.com/job-id. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
spur.ai is not a domain we own. Kubernetes best practices require that CRD API groups, label prefixes, and RBAC apiGroups use a domain controlled by the organization. Switch to spur.amd.com across CRD definitions, labels, RBAC rules, and documentation.
shiv-tyagi
force-pushed
the
refactor/rename-spur-ai-to-spur-amd-com
branch
from
d6c96b3 to
312dc3f
Compare
shiv-tyagi
requested review from
powderluv,
sgopinath1 and
yansun1996
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
spur.aireferences withspur.amd.comacross CRD definitions, labels, RBAC rules, and documentation.spur.aiis not a domain we own and K8s best practices require using a domain your organization controls for CRD API groups and label prefixes.What changed
spur_client.rs)spur.aispur.amd.comspur.ai/session-id,spur.ai/managed-by,spur.ai/job-idspur.amd.com/session-id,spur.amd.com/managed-by,spur.amd.com/job-idspur.aispur.amd.comspur.ai/managed,spur.ai/gpu-typespur.amd.com/managed,spur.amd.com/gpu-type4 files changed, pure find-and-replace. Build passes cleanly.
Breaking change
This must be deployed together with the corresponding spur repo change — the CRD group changes from
spur.aitospur.amd.com.Test plan
cargo build— cleancargo fmt --check --all— cleanspur.aioccurrences in the repo