[rocprofiler-compute] Bump scipy test pin for Python 3.13 support#7784
Open
vedithal-amd wants to merge 1 commit into
Open
[rocprofiler-compute] Bump scipy test pin for Python 3.13 support#7784vedithal-amd wants to merge 1 commit into
vedithal-amd wants to merge 1 commit into
Conversation
- scipy 1.11.4 pins Cython <3.0, which fails to build on CPython 3.13. - Bump to scipy 1.14.1, the first release with a cp313 wheel; numpy 1.26.4 stays. Co-Authored-By: Claude Opus 4 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates rocprofiler-compute’s test-only Python dependency pin to ensure SciPy installs successfully on Python 3.13 (where SciPy 1.11.4 fails to build/install).
Changes:
- Bump
scipyinrequirements-test.txtfrom1.11.4to1.14.1(keeping the runtimenumpy==1.26.4pin unchanged inrequirements.txt).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
feizheng10
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
scipy 1.11.4 fails to install on Python 3.13: it pins legacy Cython <3.0, which cannot compile against the CPython 3.13 C-API. Bump the test pin to scipy 1.14.1, keeping numpy 1.26.4 unchanged.
Technical Details
JIRA ID
ROCM-26919
Test Plan
Test Result
Verified on Python 3.13: scipy 1.14.1 installs against the existing numpy 1.26.4 pin, with no change to test behavior.
Submission Checklist