Fix LDS and GPR count on gfx11, gfx12, gfx1250#7772
Merged
Conversation
ApoKalipse-V
changed the title
venkat1361
reviewed
Jun 24, 2026
venkat1361
left a comment
venkat1361
left a comment
Contributor
There was a problem hiding this comment.
shouldn't we also change args in unit tests https://github.com/ROCm/rocm-systems/blob/users/gbaraldi/sgprcount/projects/rocprof-trace-decoder/test/unit/trace_parser_test.cpp#L30?
Contributor
Author
Done. Missed that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
rocprof-trace-decoder is returning the wrong LDS and GPR count for most GPUs, except MI300.
JIRA ID
AIPROFSDK-932
Test Plan
Tested locally. Due to time pressure, automated tests will follow in a different PR.
Submission Checklist