[rocprofiler-compute] Remove the CSV profile backend (Phase A)#7768
Draft
jamessiddeley-amd wants to merge 10 commits into
Draft
[rocprofiler-compute] Remove the CSV profile backend (Phase A)#7768jamessiddeley-amd wants to merge 10 commits into
jamessiddeley-amd wants to merge 10 commits into
Conversation
Adds docs/design/clean_architecture.md proposing a single profile data boundary with reader/writer interfaces ahead of upcoming default rocpd profiling output and other file format work. Docs-only; no code changes. Co-authored-by: Cursor <cursoragent@cursor.com>
…/rocm-systems into users/jamessiddeley-amd/design-doc-refactor-profile-boundaries
…/rocm-systems into users/jamessiddeley-amd/design-doc-refactor-profile-boundaries
github-actions
Bot
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
rocpd
.dbis now the canonical profile output. Keeping the legacy CSV profile backend forces two parallel storage formats, requires "not supported in CSV" caveats on every new feature, and drags csv-only conversion code (and its tests) along with it. This is Phase A of the profile-interface refactor: remove the CSV profile backend so there is a single storage format, before theprofiling_databoundary lands.See the design doc (Phase A): (#7424)
Technical Details
--format-rocprof-outputflag and the rocpd->csv fallback; rocpd is the only profile output format.run_profto the rocpd-only path and delete the csv-only conversion helpers (process_rocprofv3_output,v3_counter_csv_to_v2_csv,convert_native_counter_collection_csv,process_kokkos_trace_output).utils_profile_csv.py, keeping the stdlib csv I/O the rocpd path still needs.Scope note:
results_*.csvandutils_profile_csv.pyare intentionally kept. The rocpd path still makesresults_*.csvand analyze still reads it; removing that intermediate (and having analyze read directly from.db) is Phase B. This is a small data-path change but a large code deletion (around 2.9k lines which is mostly tests and dead csv helpers).JIRA ID
Phased implementation for AIPROFCOMP-593
Test Plan
test_utils,test_utils_profile_csv,test_profile_general,test_profiler_base).rufflint on changed files.format_rocprof_output/--format-rocprof-output.Test Result
Submission Checklist