Users/bimani/rocm 21691 cas implementation correctness#7754
Open
bimaniamd wants to merge 2 commits into
Open
Conversation
The current rocrtstFunc.Memory_Alignment_Test only verifies whether
the HSA_REGION_INFO_RUNTIME_ALLOC_ALIGNMENT queries return a value
that is a power-of-two.
Expanding the current Test; so that it also does memory Allocations
for each memory pool,and makes sure that the pointer returned is valid.
AILIROCR-95
Currently the implementations in InterruptSignal (e.g. InterruptSignal::CasAcqRel) call SetEvent() unconditionally resulting in spurious wakes for any waiting agent in cases where the signal does not have the expected value we check to see if the observed value is the same as the expected value and only then SetEvent() is invoked. ROCM_-21691
bimaniamd
requested review from
atgutier,
cfreeamd,
dayatsin-amd,
kentrussell and
shwetagkhatri
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Technical Details
JIRA ID
Test Plan
Test Result
Submission Checklist