[BUILD] Fix build failure against rocm-6.0.0 #2747
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…evelop/codambro_rccl-tests/rocm-6.0.0-fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Build failure seen when building against rocm-6.0.0
Work item: resolves #133
What were the changes?
no fp8 support before rocm 6.2.0
Why were the changes made?
Build errors seen with older rocm
How was the outcome achieved?
Fix version check
Additional Documentation:
Verified build and testing succeeded against rocm-6.0.0. Should have no affect on 6.2.0 and newer
🔁 Imported from ROCm/rccl-tests#134
🧑💻 Originally authored by @codambro