[hip-tests] Move __hipGetPCH out of bit_extract and add some context #1928
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR extracts the __hipGetPCH functionality test from the bit_extract sample into a dedicated test file, improving code organization and adding documentation about this legacy API.
Key changes:
- Created a new
get_hip_pchtest sample with proper context and documentation - Removed the unrelated
__hipGetPCHtest code frombit_extract - Added explanatory comments about the legacy nature and historical usage of the PCH API
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| projects/hip-tests/samples/0_Intro/get_hip_pch/get_hip_pch.cpp | New test file dedicated to testing __hipGetPCH functionality with proper error checking and context |
| projects/hip-tests/samples/0_Intro/get_hip_pch/README.md | Documentation for the new get_hip_pch test |
| projects/hip-tests/samples/0_Intro/get_hip_pch/CMakeLists.txt | Build configuration for the new test |
| projects/hip-tests/samples/0_Intro/bit_extract/bit_extract.cpp | Removed unrelated __hipGetPCH test code |
| projects/hip-tests/samples/0_Intro/bit_extract/CMakeLists.txt | Removed PCH-related build configuration no longer needed |
| projects/hip-tests/samples/0_Intro/CMakeLists.txt | Added the new get_hip_pch subdirectory to the build |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jmmartinez
force-pushed
the
users/jmmartinez/hip-tests/getPCH
branch
from
d94f485 to
1f6e24a
Compare
jamessiddeley-amd
pushed a commit
that referenced
this pull request
Dec 11, 2025
Merge pull request #1928 from corey-derochie-amd/2.27.7-sync
Contributor
Author
|
@ROCm/hip-tests-reviewers ping :) |
Contributor
Author
@ROCm/hip-tests-reviewers ping :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently there is a wild unrelated
__hipGetPCHcall inside thebit_extracttest.This function is pretty much legacy; but in the meantime, lets move it to its own test and not leave it polluting
bit_extract.This was originally submitted to ROCm/hip-tests#471 .