Skip to content

feat(stinkytofu): add stinkytofu logicalIR adapter as alternative rocisa backend#8895

Open
jimbochi wants to merge 119 commits into
developfrom
users/yuchi/stinkytofu-logicalir
Open

feat(stinkytofu): add stinkytofu logicalIR adapter as alternative rocisa backend#8895
jimbochi wants to merge 119 commits into
developfrom
users/yuchi/stinkytofu-logicalir

Conversation

@jimbochi

Copy link
Copy Markdown
Member

Motivation

Technical Details

Test Plan

Test Result

Submission Checklist

@therock-pr-bot

therock-pr-bot Bot commented Jun 29, 2026

Copy link
Copy Markdown

❌ PR Check — Action Required

Check Status Details
🌿 Branch Name ✅ Pass
📝 PR Title/Description ❌ Fail Error: PR description must reference a JIRA ID, ISSUE ID, or a GitHub closing keyword.
Expected: include a JIRA ID / ISSUE ID line (separator : or -, or omitted; value may be a JIRA key, a number with/without #, or a link), OR a closing keyword + issue reference. Accepted examples:
JIRA ID : TESTAUTO-6039
JIRA ID - #330
JIRA ID #330
ISSUE ID : TESTUTO-3334
ISSUE ID #3334
ISSUE ID - TESTAUTO-3433
ISSUE ID : https://github.com/<org_name>/<repo_name>/issues/1234
Closes #10
Fixes octo-org/octo-repo#100
Resolves: #123
#123
https://github.com/<org_name>/<repo_name>/issues/123
Current: no valid JIRA/ISSUE/closing-keyword reference found
Forbidden Files ✅ Pass
🧪 Unit Test ✅ Pass
🔎 pre-commit ❌ Fail Error: Check concluded with failure.
🚫 Draft PR 🔜 To Be Enabled
🚩 Feature Flag 🔜 To Be Enabled
📊 Code Coverage 🔜 To Be Enabled

⚠️ 2 policy check(s) failed. Please address the issues above before this PR can be Reviewed.

🚫 Please fix the failed policies

  • ❌ PR Title/Description
  • ❌ pre-commit

The Not ready to Review label was added to this PR. Once all policies pass, the label is removed automatically.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

@therock-pr-bot

Copy link
Copy Markdown

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

  • ❌ PR Title/Description

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

@codecov-commenter

codecov-commenter commented Jun 29, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 70 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ts/hipblaslt/tensilelite/rocisa/rocisa/__init__.py 0.00% 61 Missing ⚠️
...ects/hipblaslt/tensilelite/Tensile/KernelWriter.py 0.00% 9 Missing ⚠️

❌ Your project status has failed because the head coverage (33.43%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #8895       +/-   ##
============================================
- Coverage    65.14%   33.43%   -31.70%     
============================================
  Files         2628      132     -2496     
  Lines       413042    59250   -353792     
  Branches     61873    12291    -49582     
============================================
- Hits        269042    19810   -249232     
+ Misses      123489    37481    -86008     
+ Partials     20511     1959    -18552     
Flag Coverage Δ
TensileLite 33.43% <0.00%> (-0.03%) ⬇️
hipBLAS ?
hipBLASLt ?
hipCUB ?
hipDNN ?
hipFFT ?
hipRAND ?
hipSOLVER ?
hipSPARSE ?
rocBLAS ?
rocFFT ?
rocRAND ?
rocSOLVER ?
rocSPARSE ?
rocThrust ?
Files with missing lines Coverage Δ
...ects/hipblaslt/tensilelite/Tensile/KernelWriter.py 11.63% <0.00%> (-0.01%) ⬇️
...ts/hipblaslt/tensilelite/rocisa/rocisa/__init__.py 0.00% <0.00%> (ø)

... and 2496 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Alex-Vasile Alex-Vasile left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a full PR description. This PR is not reviewable in its current state.

@jimbochi jimbochi force-pushed the users/yuchi/stinkytofu-logicalir branch from d543030 to 9ea4520 Compare July 3, 2026 05:01
@jimbochi jimbochi changed the title Add stinkytofu logicalIR adapter as alternative rocisa backend feat(stinkytofu): add stinkytofu logicalIR adapter as alternative rocisa backend Jul 3, 2026
jimbochi added 27 commits July 3, 2026 08:07
…pping and preserve True16 register structure
@jimbochi jimbochi force-pushed the users/yuchi/stinkytofu-logicalir branch from be43f1b to 4596502 Compare July 3, 2026 08:08
@KKyang

KKyang commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Couple things:

  1. rocisa/CMakeLists.txt shouldn't couple to stinkytofu unconditionally — right now it always add_subdirectory(shared/stinkytofu) + forces BUILD_SHARED_LIBS=ON when the sibling dir exists, and rocisa/__init__.py always tries importing the adapter when ROCISA_BACKEND=stinkytofu is set, with no arch check. This should be decoupled cleanly: gfx1250+ imports stinkytofu, everything else stays on native rocisa with no stinkytofu in the build/import path at all.

  2. New files have the legacy MIT header instead of SPDX (tensilelite/CLAUDE.md requires SPDX for new files). At least rocisa_stinkytofu_adaptor/__init__.py and base.py have it — looks like it's the copy-paste template for the whole package so probably worth fixing once at the source.

Rest of what I found is either dead code given gfx1250-only scope right now or already called out as a known gap in the PR's own notes, so not blocking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants