Skip to content

[hipSOLVER][rocSOLVER] Pin build-time dependency fetches to immutable commits #8794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
qjojo wants to merge 2 commits into
base: develop
Choose a base branch
from
+31 −33
Open

[hipSOLVER][rocSOLVER] Pin build-time dependency fetches to immutable commits #8794

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54647bd
[hipSOLVER][rocSOLVER] Pin build-time dependency fetches to immutable…
qjojo Jun 24, 2026
9ecd7d4
Pin rocm-cmake to the rocm-6.4.0 commit used by sibling libraries
qjojo Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion projects/hipsolver/cmake/get-rocm-cmake.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,10 @@ if(NOT ROCmCMakeBuildTools_FOUND)
if(NOT ROCM_FOUND)
include(FetchContent)
message(STATUS "ROCmCMakeBuildTools not found. Fetching...")
set(rocm_cmake_tag "develop" CACHE STRING "rocm-cmake tag to download")
# pinned-dep rocm-cmake: immutable commit (was the mutable "develop" branch).
# Corresponds to the therock-7.13 tag. Bump at each ROCm release cut.

@tfalders tfalders Jun 24, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to add something to the bump script to do the bump automatically or remind us.

# grep "pinned-dep" to find every pin that needs bumping.
set(rocm_cmake_tag "10155d7272ea1bf79f6b5a9dbc339657af1aa372" CACHE STRING "rocm-cmake commit to download (therock-7.13)")
FetchContent_Declare(
rocm-cmake
GIT_REPOSITORY https://github.com/ROCm/rocm-cmake.git
Expand Down
7 changes: 5 additions & 2 deletions projects/hipsolver/deps/external-gtest.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# ########################################################################
# Copyright (C) 2016-2024 Advanced Micro Devices, Inc. All rights reserved.
# Copyright (C) 2016-2026 Advanced Micro Devices, Inc. All rights reserved.
#
# Permission is hereby granted, free of charge, to any person obtaining a copy
# of this software and associated documentation files (the "Software"), to deal
Expand Down Expand Up @@ -30,7 +30,10 @@ set(gtest_cmake_args -DCMAKE_INSTALL_PREFIX=${PREFIX_GTEST})
append_cmake_cli_arguments(gtest_cmake_args gtest_cmake_args)

set(gtest_git_repository "https://github.com/google/googletest.git" CACHE STRING "URL to download gtest from")
set(gtest_git_tag "release-1.11.0" CACHE STRING "URL to download gtest from")
# pinned-dep googletest: immutable commit (was the mutable "release-1.11.0" tag).
# Bump only on a deliberate googletest upgrade.
# grep "pinned-dep" to find every pin that needs bumping.
set(gtest_git_tag "e2239ee6043f73722e7aa812a459f54a28552929" CACHE STRING "googletest commit (release-1.11.0)")

if(MSVC)
list(APPEND gtest_cmake_args -Dgtest_force_shared_crt=ON)
Expand Down
7 changes: 5 additions & 2 deletions projects/hipsolver/deps/external-lapack.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# ########################################################################
# Copyright (C) 2016-2022 Advanced Micro Devices, Inc. All rights reserved.
# Copyright (C) 2016-2026 Advanced Micro Devices, Inc. All rights reserved.
#
# Permission is hereby granted, free of charge, to any person obtaining a copy
# of this software and associated documentation files (the "Software"), to deal
Expand Down Expand Up @@ -29,7 +29,10 @@ set(lapack_cmake_args -DCMAKE_INSTALL_PREFIX=${PREFIX_LAPACK})
append_cmake_cli_arguments(lapack_cmake_args lapack_cmake_args)

set(lapack_git_repository "https://github.com/Reference-LAPACK/lapack-release" CACHE STRING "URL to download lapack from")
set(lapack_git_tag "lapack-3.7.1" CACHE STRING "git branch")
# pinned-dep lapack: immutable commit (was the mutable "lapack-3.7.1" branch).
# Same commit as the v3.7.1 tag in Reference-LAPACK/lapack. Bump only on a deliberate LAPACK upgrade.
# grep "pinned-dep" to find every pin that needs bumping.
set(lapack_git_tag "9f7abc2cc93fac3a5a8905307447c70163abdef2" CACHE STRING "lapack commit (v3.7.1)")

# message(STATUS "lapack_make (" ${lapack_make} ") ")
# message(STATUS "lapack_cmake_args (" ${lapack_cmake_args} ") ")
Expand Down
43 changes: 15 additions & 28 deletions projects/rocsolver/cmake/get-rocm-cmake.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
# This finds the rocm-cmake project, and installs it if not found
# rocm-cmake contains common cmake code for rocm projects to help setup and install
set(PROJECT_EXTERN_DIR ${CMAKE_CURRENT_BINARY_DIR}/extern)

# By default, rocm software stack is expected at /opt/rocm
# set environment variable ROCM_PATH to change location
Expand All @@ -10,33 +9,21 @@ endif()

find_package(ROCmCMakeBuildTools QUIET PATHS ${ROCM_PATH})
if(NOT ROCmCMakeBuildTools_FOUND)
find_package(ROCM 0.7.3 CONFIG QUIET PATHS ${ROCM_PATH})
find_package(ROCM 0.7.3 CONFIG QUIET PATHS ${ROCM_PATH}) # deprecated fallback
if(NOT ROCM_FOUND)
set(rocm_cmake_tag "master" CACHE STRING "rocm-cmake tag to download")
set(rocm_cmake_url "https://github.com/RadeonOpenCompute/rocm-cmake/archive/${rocm_cmake_tag}.zip")
set(rocm_cmake_path "${PROJECT_EXTERN_DIR}/rocm-cmake-${rocm_cmake_tag}")
set(rocm_cmake_archive "${rocm_cmake_path}.zip")
file(DOWNLOAD "${rocm_cmake_url}" "${rocm_cmake_archive}" STATUS status LOG log)

list(GET status 0 status_code)
list(GET status 1 status_string)

if(status_code EQUAL 0)
message(STATUS "downloading... done")
else()
message(FATAL_ERROR "error: downloading\n'${rocm_cmake_url}' failed
status_code: ${status_code}
status_string: ${status_string}
log: ${log}\n")
endif()

execute_process(COMMAND ${CMAKE_COMMAND} -E tar xzvf "${rocm_cmake_archive}"
WORKING_DIRECTORY ${PROJECT_EXTERN_DIR})
execute_process( COMMAND ${CMAKE_COMMAND} -DCMAKE_INSTALL_PREFIX=${PROJECT_EXTERN_DIR}/rocm-cmake .
WORKING_DIRECTORY ${PROJECT_EXTERN_DIR}/rocm-cmake-${rocm_cmake_tag} )
execute_process( COMMAND ${CMAKE_COMMAND} --build rocm-cmake-${rocm_cmake_tag} --target install
WORKING_DIRECTORY ${PROJECT_EXTERN_DIR})

find_package( ROCM 0.7.3 REQUIRED CONFIG PATHS ${PROJECT_EXTERN_DIR}/rocm-cmake )
include(FetchContent)
message(STATUS "ROCmCMakeBuildTools not found. Fetching...")
# pinned-dep rocm-cmake: immutable commit (was the mutable "master" branch).
# Corresponds to the therock-7.13 tag. Bump at each ROCm release cut.
# grep "pinned-dep" to find every pin that needs bumping.
set(rocm_cmake_tag "10155d7272ea1bf79f6b5a9dbc339657af1aa372" CACHE STRING "rocm-cmake commit to download (therock-7.13)")
FetchContent_Declare(
rocm-cmake
GIT_REPOSITORY https://github.com/ROCm/rocm-cmake.git
GIT_TAG ${rocm_cmake_tag}
SOURCE_SUBDIR "DISABLE ADDING TO BUILD" # We don't want to consume rocm-cmake's own build/test targets.
)
FetchContent_MakeAvailable(rocm-cmake)
find_package(ROCmCMakeBuildTools CONFIG REQUIRED NO_DEFAULT_PATH PATHS "${rocm-cmake_SOURCE_DIR}")
endif()
endif()
Loading