[origami] Add catastrophic fallback to rank_configs#8793
Open
bethune-bryant wants to merge 1 commit into
Open
Conversation
When every candidate is rejected by capacity or latency checks, rank the invalid configs instead of throwing so selection can still return a kernel. Co-authored-by: Cursor <cursoragent@cursor.com>
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (77.89%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #8793 +/- ##
========================================
Coverage 71.50% 71.50%
========================================
Files 2612 2612
Lines 407895 407895
Branches 60982 60982
========================================
Hits 291636 291636
Misses 94875 94875
Partials 21384 21384
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rank_configsrejects every candidate (LDS/RF capacity or max latency), fall back to ranking the invalid configs instead of throwingNo valid configs found.valid_configsandinvalid_configs, with a sharedcompute_ranked_latencyhelper for GEMM and attention paths.origami.hpp.Test plan
./tests/origami-tests "Origami: rank_configs unit test"(36 assertions)Made with Cursor