[hiprand] Skip a couple of long-running tests from the ffm-quick category#8791
Open
amd-hsong wants to merge 1 commit into
Open
[hiprand] Skip a couple of long-running tests from the ffm-quick category#8791amd-hsong wants to merge 1 commit into
amd-hsong wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (77.89%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #8791 +/- ##
========================================
Coverage 71.43% 71.43%
========================================
Files 2612 2612
Lines 407002 407002
Branches 60775 60775
========================================
Hits 290729 290729
Misses 94967 94967
Partials 21306 21306
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
test_hiprand_apiandtest_hiprand_cpp_wrappertimeout on FFM simulation. They can successfully finish if given enough time. This PR excludes them from theffm-quickcategory.Technical Details
Their slowness is caused by the mt19937 generator's initialization kernel (
jump_ahead_mt19937). It is very expensive because of 1) large grid size: 8,192 blocks × 128 threads = ~1M threads, and 2) 19,937 iteration loop per block with__syncthreads()on every iteration and conditional shared memory writes gated by global memory reads.Test Plan
Run
ctest -L ffm-quick. These two tests should be skipped.Test Result
These two tests are included in
quick/standard/fullcategories but not inffm-quick.Submission Checklist