Skip to content

[hipblaslt] Fix yaml dtypes in utilities folder#8772

Merged
Alex-Vasile merged 1 commit into
developfrom
users/alvasile/yaml_script_fixup
Jun 25, 2026
Merged

[hipblaslt] Fix yaml dtypes in utilities folder#8772
Alex-Vasile merged 1 commit into
developfrom
users/alvasile/yaml_script_fixup

Conversation

@Alex-Vasile

Copy link
Copy Markdown
Contributor

Motivation

Cleanup wrong dtypes (e.g. bool instead of int)

Technical Details

  1. Fix hardcoded dtypes in utils.
  2. Make helper script call the conversion function to prevent new yamls from being created with wrong dtypes.

Test Plan

Run existing tests.

Test Result

Pass.

Submission Checklist

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

❌ Your project status has failed because the head coverage (77.89%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8772   +/-   ##
========================================
  Coverage    71.43%   71.44%           
========================================
  Files         2612     2612           
  Lines       407038   407032    -6     
  Branches     60777    60778    +1     
========================================
+ Hits        290766   290767    +1     
+ Misses       94969    94961    -8     
- Partials     21303    21304    +1     
Flag Coverage Δ *Carryforward flag
TensileLite 76.81% <ø> (ø) Carriedforward from 4832985
hipBLAS 90.81% <ø> (ø) Carriedforward from 4832985
hipBLASLt 41.36% <ø> (+0.02%) ⬆️
hipCUB 82.68% <ø> (ø) Carriedforward from 4832985
hipDNN 86.74% <ø> (ø) Carriedforward from 4832985
hipFFT 50.79% <ø> (ø) Carriedforward from 4832985
hipRAND 76.12% <ø> (ø) Carriedforward from 4832985
hipSOLVER 69.18% <ø> (ø) Carriedforward from 4832985
hipSPARSE 86.55% <ø> (ø) Carriedforward from 4832985
rocBLAS 48.08% <ø> (ø) Carriedforward from 4832985
rocFFT 47.22% <ø> (ø) Carriedforward from 4832985
rocRAND 57.07% <ø> (ø) Carriedforward from 4832985
rocSOLVER 77.89% <ø> (ø) Carriedforward from 4832985
rocSPARSE 72.37% <ø> (ø) Carriedforward from 4832985
rocThrust 91.34% <ø> (ø) Carriedforward from 4832985

*This pull request uses carry forward flags. Click here to find out more.
see 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Alex-Vasile Alex-Vasile enabled auto-merge (squash) June 24, 2026 19:39

@newling newling left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Alex-Vasile Alex-Vasile merged commit 9cbf8ca into develop Jun 25, 2026
61 of 68 checks passed
@Alex-Vasile Alex-Vasile deleted the users/alvasile/yaml_script_fixup branch June 25, 2026 00:53
assistant-librarian Bot pushed a commit to ROCm/hipBLASLt that referenced this pull request Jun 25, 2026
[hipblaslt] Fix yaml dtypes in utilities folder

## Motivation

Cleanup wrong dtypes (e.g. bool instead of int)

## Technical Details

1. Fix hardcoded dtypes in utils.
2. Make helper script call the conversion function to prevent new yamls
from being created with wrong dtypes.

## Test Plan

Run existing tests.

## Test Result

Pass.

## Submission Checklist

- [x] Look over the contributing guidelines at
https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants