[rocisa][stinkytofu] Move rocisa conversion glue out of stinkytofu#8765
Open
KKyang wants to merge 1 commit into
Open
[rocisa][stinkytofu] Move rocisa conversion glue out of stinkytofu#8765KKyang wants to merge 1 commit into
KKyang wants to merge 1 commit into
Conversation
The conversion sources (AllHwMappings, ToStinkyTofuUtils, *ArchInfo headers) are rocisa-side bindings — they include rocisa headers, reference rocisa types, and are compiled into _rocisa, not libstinkytofu. Moving them to rocisa/src/stinkytofu/ makes ownership explicit and removes the cross-repo source path hack from rocisa's CMakeLists. GenRocisaHwMapping.cpp stays in stinkytofu's tablegen (it needs gfxisa internals) but is marked for removal when rocisa is replaced by stinkytofu IR.
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (77.89%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #8765 +/- ##
========================================
Coverage 71.43% 71.43%
========================================
Files 2612 2612
Lines 407038 407038
Branches 60777 60777
========================================
Hits 290766 290766
Misses 94969 94969
Partials 21303 21303
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AllHwMappings.cpp/.hpp,ToStinkyTofuUtils.cpp,RocisaArchInfo.hpp, andGfx1250RocisaArchInfo.hppfromshared/stinkytofu/src/conversion/rocisa/toprojects/hipblaslt/tensilelite/rocisa/rocisa/src/stinkytofu/init_stinkytofu) that compile into_rocisa— notlibstinkytofu. Moving them makes ownership explicit._stinkytofu_src_dir) from rocisa's CMakeLists; sources are now referenced locally.GenRocisaHwMapping.cppstays in stinkytofu's tablegen (requiresgfxisainternals) but is marked TODO for removal when rocisa is replaced by stinkytofu IR.Test plan
scikit-build-core) compiles cleanlyfind_package(stinkytofu)build compiles cleanly