Skip to content

[hipSPARSELt] Remove legacy hip kernel launcher backend#8754

Open
vin-huang wants to merge 1 commit into
developfrom
users/vinhuang/remove_hip_backend
Open

[hipSPARSELt] Remove legacy hip kernel launcher backend#8754
vin-huang wants to merge 1 commit into
developfrom
users/vinhuang/remove_hip_backend

Conversation

@vin-huang

@vin-huang vin-huang commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Motivation

The spmm/hip/ directory contained a legacy standalone HIP kernel launcher
backend (KernelLauncher, KernelArguments, SolutionAdapter) that predates
the TensileLite integration. Since the build exclusively uses TensileLite
(BUILD_WITH_TENSILE is always defined), this code is dead and can be removed
to reduce maintenance burden and eliminate unused code paths.

Technical Details

Remove the spmm/hip/ folder and all associated files that implemented the
non-Tensile kernel dispatch path:

Files deleted:

  • library/src/hcc_detail/rocsparselt/src/spmm/hip/hip_solution_adapter.cpp
  • library/src/hcc_detail/rocsparselt/src/spmm/hip/kernel_arguments.cpp
  • library/src/hcc_detail/rocsparselt/src/spmm/hip/kernel_launcher.cpp
  • library/src/hcc_detail/rocsparselt/src/include/hip_solution_adapter.hpp
  • library/src/hcc_detail/rocsparselt/src/include/kernel_arguments.hpp
  • library/src/hcc_detail/rocsparselt/src/include/kernel_launcher.hpp

Files modified:

Simplified the #if BUILD_WITH_TENSILE / #else / #endif conditional include
blocks in the following files by removing the dead #else branches and
unconditionally including tensile_host.hpp:

  • library/src/hcc_detail/rocsparselt/src/rocsparselt_auxiliary.cpp
  • library/src/hcc_detail/rocsparselt/src/spmm/rocsparselt_spmm.hpp
  • library/src/hcc_detail/rocsparselt/src/include/rocsparselt_spmm_utils.hpp

No CMakeLists.txt changes are required as the spmm/hip/ source files were
never listed in the build system.

Test Plan

  • Build hipSPARSELt with TensileLite enabled (-DHIPSPARSELT_ENABLE_TENSILELITE=ON)
    and verify compilation succeeds with no missing header errors.
  • Run existing hipSPARSELt unit tests (hipsparselt-test) to confirm no
    regressions in spmm/compress/prune functionality.

Test Result

  • Build successful, no compilation errors.
  • All existing spmm unit tests pass.

Submission Checklist

https://amd-hub.atlassian.net/browse/ROCM-26968

Remove the spmm/hip/ directory and its associated files that implemented
a standalone HIP kernel launcher backend, which has been deprecated.
Clean up all references to the removed code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant