[hipSPARSELt] Remove legacy hip kernel launcher backend#8754
Open
vin-huang wants to merge 1 commit into
Open
Conversation
Remove the spmm/hip/ directory and its associated files that implemented a standalone HIP kernel launcher backend, which has been deprecated. Clean up all references to the removed code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The
spmm/hip/directory contained a legacy standalone HIP kernel launcherbackend (
KernelLauncher,KernelArguments,SolutionAdapter) that predatesthe TensileLite integration. Since the build exclusively uses TensileLite
(
BUILD_WITH_TENSILEis always defined), this code is dead and can be removedto reduce maintenance burden and eliminate unused code paths.
Technical Details
Remove the
spmm/hip/folder and all associated files that implemented thenon-Tensile kernel dispatch path:
Files deleted:
library/src/hcc_detail/rocsparselt/src/spmm/hip/hip_solution_adapter.cpplibrary/src/hcc_detail/rocsparselt/src/spmm/hip/kernel_arguments.cpplibrary/src/hcc_detail/rocsparselt/src/spmm/hip/kernel_launcher.cpplibrary/src/hcc_detail/rocsparselt/src/include/hip_solution_adapter.hpplibrary/src/hcc_detail/rocsparselt/src/include/kernel_arguments.hpplibrary/src/hcc_detail/rocsparselt/src/include/kernel_launcher.hppFiles modified:
Simplified the
#if BUILD_WITH_TENSILE / #else / #endifconditional includeblocks in the following files by removing the dead
#elsebranches andunconditionally including
tensile_host.hpp:library/src/hcc_detail/rocsparselt/src/rocsparselt_auxiliary.cpplibrary/src/hcc_detail/rocsparselt/src/spmm/rocsparselt_spmm.hpplibrary/src/hcc_detail/rocsparselt/src/include/rocsparselt_spmm_utils.hppNo CMakeLists.txt changes are required as the
spmm/hip/source files werenever listed in the build system.
Test Plan
-DHIPSPARSELT_ENABLE_TENSILELITE=ON)and verify compilation succeeds with no missing header errors.
hipsparselt-test) to confirm noregressions in spmm/compress/prune functionality.
Test Result
Submission Checklist
https://amd-hub.atlassian.net/browse/ROCM-26968