Skip to content

Restrict rocfft/hipfft concurrency by omp max threads.#8743

Open
malcolmroberts wants to merge 5 commits into
ROCm:developfrom
malcolmroberts:minompmax
Open

Restrict rocfft/hipfft concurrency by omp max threads.#8743
malcolmroberts wants to merge 5 commits into
ROCm:developfrom
malcolmroberts:minompmax

Conversation

@malcolmroberts

Copy link
Copy Markdown
Contributor

Motivation

Allow the user to restrict the concurrency for rocFFT/hipFFT by setting OMP thread limits

Technical Details

We take the minimum of omp_get_max_threads and the hardware concurrency.

Test Plan

Testing by usual CI

Test Result

Run CI

Submission Checklist

Comment thread projects/hipfft/shared/concurrency.h
@codecov-commenter

codecov-commenter commented Jun 23, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
projects/rocfft/shared/concurrency.h 75.00% 1 Missing ⚠️

❌ Your project status has failed because the head coverage (48.47%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8743      +/-   ##
===========================================
+ Coverage    71.43%   71.52%   +0.09%     
===========================================
  Files         2612     2612              
  Lines       407002   407021      +19     
  Branches     60775    60770       -5     
===========================================
+ Hits        290729   291103     +374     
+ Misses       94967    94659     -308     
+ Partials     21306    21259      -47     
Flag Coverage Δ *Carryforward flag
TensileLite 76.81% <ø> (ø) Carriedforward from acf8006
hipBLAS 90.81% <ø> (ø) Carriedforward from acf8006
hipBLASLt 41.33% <ø> (ø) Carriedforward from acf8006
hipCUB 82.68% <ø> (ø) Carriedforward from acf8006
hipDNN 86.72% <ø> (ø) Carriedforward from acf8006
hipFFT 49.92% <ø> (-0.87%) ⬇️
hipRAND 76.12% <ø> (ø) Carriedforward from acf8006
hipSOLVER 69.18% <ø> (ø) Carriedforward from acf8006
hipSPARSE 86.55% <ø> (ø) Carriedforward from acf8006
rocBLAS 48.08% <ø> (ø) Carriedforward from acf8006
rocFFT 48.47% <75.00%> (+1.25%) ⬆️
rocRAND 57.07% <ø> (ø) Carriedforward from acf8006
rocSOLVER 77.89% <ø> (ø) Carriedforward from acf8006
rocSPARSE 72.37% <ø> (ø) Carriedforward from acf8006
rocThrust 91.34% <ø> (ø) Carriedforward from acf8006

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
projects/rocfft/shared/concurrency.h 75.00% <75.00%> (+12.50%) ⬆️

... and 44 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@malcolmroberts malcolmroberts requested a review from evetsso June 24, 2026 19:13
@malcolmroberts malcolmroberts enabled auto-merge (squash) June 24, 2026 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants