Restrict rocfft/hipfft concurrency by omp max threads.#8743
Open
malcolmroberts wants to merge 5 commits into
Open
Restrict rocfft/hipfft concurrency by omp max threads.#8743malcolmroberts wants to merge 5 commits into
malcolmroberts wants to merge 5 commits into
Conversation
evetsso
reviewed
Jun 23, 2026
Codecov Report❌ Patch coverage is
❌ Your project status has failed because the head coverage (48.47%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #8743 +/- ##
===========================================
+ Coverage 71.43% 71.52% +0.09%
===========================================
Files 2612 2612
Lines 407002 407021 +19
Branches 60775 60770 -5
===========================================
+ Hits 290729 291103 +374
+ Misses 94967 94659 -308
+ Partials 21306 21259 -47
*This pull request uses carry forward flags. Click here to find out more.
🚀 New features to boost your workflow:
|
evetsso
approved these changes
Jun 24, 2026
regan-amd
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Allow the user to restrict the concurrency for rocFFT/hipFFT by setting OMP thread limits
Technical Details
We take the minimum of omp_get_max_threads and the hardware concurrency.
Test Plan
Testing by usual CI
Test Result
Run CI
Submission Checklist