Fix: Add coverage-focused test suite and wrapper script to improve code coverage for hipblaslt#8698
Open
pdhirajkumarprasad wants to merge 3 commits into
Open
Conversation
…verage This commit adds infrastructure to measure and improve code coverage: 1. **New test file**: coverage_focused_gtest.yaml (69 test definitions) - Grouped GEMM operations with various configurations - Data type conversion tests (mixed precision f16/bf16/f32) - Transpose combinations (NN, NT, TN, TT) - Scaling modes (scalar, block, mixed) - Batch and stride operations - Epilogue tests (activation functions, bias handling) - Custom type tests (bf6, f6, f4) - experimental 2. **Coverage wrapper script**: cmake/run_coverage_tests.sh - Sets HIPBLASLT_LOG_MASK=255 to enable all logging paths - Sets HIPBLASLT_CHECK_NUMERICS=1 (disabled due to memory issues) - Handles test failures gracefully for coverage report generation 3. **Build integration**: - Added coverage_focused_gtest.yaml to CMakeLists.txt dependencies - Included coverage_focused_gtest.yaml in hipblaslt_gtest.yaml - Updated coverage target to report test failures while still generating reports 4. **Known bugs**: Added 7 test cases to known_bugs.yaml for unsupported features - Mixed bias types, complex grouped GEMM, scaleCD/scaleAB vector modes Expected outcome: Improve coverage from baseline to 65-70%+ by targeting high-value uncovered code in tensile_host.cpp, rocblaslt_mat_utils.hpp, and other core library files. Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com>
Signed-off-by: pdhirajkumarprasad <dhirajp@amd.com>
Contributor
Author
|
Overall summary: |
❌ PR Check — Action Required
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🚫 Please fix the failed policies before requesting reviews. The following policy checks failed:
The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds infrastructure to measure and improve code coverage:
Motivation
We are trying to improve the code coverage for
hipblasltto >80% from current ~50%. This PR is in that direction.Technical Details
New test file: coverage_focused_gtest.yaml (69 test definitions)
Coverage wrapper script: cmake/run_coverage_tests.sh
Build integration:
Known bugs: Added 7 test cases to known_bugs.yaml for unsupported features
Expected outcome: Improve coverage from baseline to 65-70%+ by targeting high-value uncovered code in tensile_host.cpp, rocblaslt_mat_utils.hpp, and other core library files.
Post this PR
Before this change:
This PR can be merged after #8470 is merged
Test Plan
N/A
Test Result
N/A
Submission Checklist