feat(tensilelite): Install tensilelite-client and fix makeIsaInfoMap singleton poisoning#8520
Merged
archana-ramalingam merged 5 commits intoJun 25, 2026
Conversation
…eton poisoning - Install tensilelite-client to libexec/hipblaslt/tensilelite for CI test artifacts (fixes FileNotFoundError in FFM emulation tests) - Move makeIsaInfoMap() from module level to pytest fixture in test_MatrixInstructionConversion.py (prevents rocisa singleton poisoning when unit + common tests are collected together) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-actions
Bot
added
project: hipblaslt
project: hipsparselt
ci:hipsparselt-fast
labels
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (77.89%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #8520 +/- ##
===========================================
- Coverage 71.43% 71.43% -0.00%
===========================================
Files 2612 2612
Lines 407002 407002
Branches 60775 60775
===========================================
- Hits 290729 290728 -1
- Misses 94967 94970 +3
+ Partials 21306 21304 -2
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
davidd-amd
reviewed
Jun 22, 2026
davidd-amd
reviewed
Jun 22, 2026
davidd-amd
approved these changes
Jun 22, 2026
… users/aramalin/tensilelite-client-fixture
archana-ramalingam
changed the title
rocm_install_targets() does not accept DESTINATION — it only parses TARGETS, EXPORT, COMPONENT, PREFIX, INCLUDE, PRIVATE. The bare DESTINATION keyword gets treated as a target name, breaking configure. Use plain install() with RUNTIME DESTINATION per the tensilelite-test-install design doc. Keep if(TENSILELITE_ENABLE_CLIENT) guard from the prior review. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Split from PR #8004 per reviewer request. These changes are prerequisites for GPU emulation testing on gfx1250.
Technical Details
CMakeLists.txt: Installtensilelite-clienttolibexec/hipblaslt/tensilelitewhen the target exists. Required for FFM emulation tests to locate the prebuilt client binary.test_MatrixInstructionConversion.py: MovevalidateToolchain()andmakeIsaInfoMap()from module level to@pytest.fixture(scope="module"). Prevents rocisa singleton poisoning when unit and common test modules are collected in the same pytest session.Test Plan
Test Result
Submission Checklist
JIRA ID: AIHPBLAS-3508