-
Notifications
You must be signed in to change notification settings - Fork 326
64-bit offset support in hipBLASLt #7585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shbae
wants to merge
25
commits into
develop
Choose a base branch
from
users/sbae/64bit_offset_support
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
68bb8e4
minor fix of the type of an internal function name.
shbae 5ae84f2
[hipblaslt] implement host-side code for the 64bit offset support in …
shbae 299f898
[hipblaslt] pass batch offset values as kernel arguments.
shbae 122c1cc
[hipblaslt] add offset parameters into the kernel signature.
shbae 5a8e6ae
[hipblaslt] update kernel generation to use offsets in general batch …
shbae ef58b1d
[hipblaslt] add waitcnt instruction after SLoadB64 before updating th…
shbae f86ea62
[hipblaslt] implement tests for 64-bit offset support
shbae c4767cc
[hipblaslt] update tensilelite code-gen part for 64bit offset support…
shbae 95f65e7
[hipblaslt] fix bugs in computeStoreSrd() and remove unnecessary change.
shbae bc1e76a
[hipblaslt] update 64-bit offset support for BetaOnly and Conversion.
shbae 75c41a7
[hipblaslt] fix bugs in the changes of KernelWriterConversion.py
shbae 9687d09
[hipblaslt] remove unnecessary if-condition and minor update.
shbae a1e6023
[hipblaslt] fix CI test failures.
shbae a5c0c37
remove temporary debug implementation.
shbae 6a04c1c
[hipblaslt] fix the bug related to CI failures.
shbae dfcb804
[hipblaslt] place the batch offset argument at the tail of the kernar…
shbae f506496
[hipblaslt] modify the batch offset value as in elements.
shbae 314abe7
remove temporary debug test and update matmul_batch_offset_large test.
shbae a1aa531
[hipblaslt] modify matmul_batch_offset_large test with actual 64-bit …
shbae 19ad018
limit the tested gpu_arch for matmul_batch_offset_large tests.
shbae 536d137
[hipblaslt] remove checking the positive offset value
shbae 74324ee
[hipblaslt] add matmul_batch_offset_all_solutions test.
shbae 905a59e
[hipblaslt] don't add batchOffset arguments to the Custom Kernels, an…
shbae d36670a
[hipblaslt] add tests for negative batch offset values.
shbae 24de4c7
[hipblaslt] check validity with non-zero offsets with POINTER_ARRAY m…
shbae File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
458 changes: 458 additions & 0 deletions
458
projects/hipblaslt/clients/common/include/testing_matmul_batch_offset.hpp
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TorreZuk I've added
matmul_batch_offset_negativeandmatmul_batch_offset_mixedtests here and they are all PASSED locally.