-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop stream 2025-01-28 #607
base: develop
Are you sure you want to change the base?
Conversation
C++17 new standard See merge request amd/libraries/rocRAND!355
Fix warnings when generating sphinx docs Closes ROCm#382 See merge request amd/libraries/rocRAND!356
Replace GitHub URL with its issue number Closes ROCm#384 See merge request amd/libraries/rocRAND!358
Update documentation generation instructions See merge request amd/libraries/rocRAND!359
Fix CI on rocm/dev-ubuntu Closes ROCm#386 See merge request amd/libraries/rocRAND!360
Make rocRAND usable from FetchContent See merge request amd/libraries/rocRAND!361
Remove extra dashes in the documentation its \param and \tparam See merge request amd/libraries/rocRAND!362
Documentation to CI upload See merge request amd/libraries/rocRAND!365
…eam' Match cuRAND benchmarks with rocRAND ones See merge request amd/libraries/rocRAND!364
…evelop_stream' Replace download_project with FetchContent Closes ROCm#388 See merge request amd/libraries/rocRAND!367
@stanleytsang-amd This is still in draft as I'm still running some internal CI, but feel free to kick of AMD's CI too. |
clang-format hang is due to llvm/llvm-project#102319 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment regarding the changelog.
CHANGELOG.md
Outdated
@@ -7,6 +7,7 @@ Documentation for rocRAND is available at | |||
|
|||
### Changed | |||
* Updated several `gfx942` auto tuning parameters. | |||
* Changed the C++ version from 14 to 17. C++14 will be deprecated in the next major release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the deprecation notice should be moved to the "Upcoming changes" section (leave the part about changing the version here).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated it in 6b70e43. Also did a similar change for the PR for hipRAND.
6b70e43
to
6c6e699
Compare
…ream_20250128' Deprecate sobol constants and vectors See merge request amd/libraries/rocRAND!374
This PR:
FetchContent
.There are also some internal changes mainly for StreamHPC's CI.