Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop stream 2025-01-28 #607

Open
wants to merge 28 commits into
base: develop
Choose a base branch
from

Conversation

Naraenda
Copy link
Member

@Naraenda Naraenda commented Jan 28, 2025

This PR:

  • 42f9830 deprecates C++14 and sets the default C++ standard to C++17.
  • 582f66a, e09fde6 fixes some documentation related issues.
  • bf5f190, f0205f8 changes dependency download to use FetchContent.
  • 871a716 updates benchmarks
  • 3254198 deprecates directly accessing sobol constants and direction vectors.

There are also some internal changes mainly for StreamHPC's CI.

NB4444 and others added 25 commits January 28, 2025 10:21
C++17 new standard

See merge request amd/libraries/rocRAND!355
Fix warnings when generating sphinx docs

Closes ROCm#382

See merge request amd/libraries/rocRAND!356
Replace GitHub URL with its issue number

Closes ROCm#384

See merge request amd/libraries/rocRAND!358
Update documentation generation instructions

See merge request amd/libraries/rocRAND!359
Fix CI on rocm/dev-ubuntu

Closes ROCm#386

See merge request amd/libraries/rocRAND!360
Make rocRAND usable from FetchContent

See merge request amd/libraries/rocRAND!361
Remove extra dashes in the documentation its \param and \tparam

See merge request amd/libraries/rocRAND!362
Documentation to CI upload

See merge request amd/libraries/rocRAND!365
…eam'

Match cuRAND benchmarks with rocRAND ones

See merge request amd/libraries/rocRAND!364
…evelop_stream'

Replace download_project with FetchContent

Closes ROCm#388

See merge request amd/libraries/rocRAND!367
@Naraenda
Copy link
Member Author

@stanleytsang-amd This is still in draft as I'm still running some internal CI, but feel free to kick of AMD's CI too.

@Naraenda Naraenda marked this pull request as ready for review January 29, 2025 07:29
@Naraenda Naraenda requested review from lawruble13 and a team as code owners January 29, 2025 07:29
@Naraenda
Copy link
Member Author

clang-format hang is due to llvm/llvm-project#102319

Copy link
Contributor

@amd-jnovotny amd-jnovotny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment regarding the changelog.

CHANGELOG.md Outdated
@@ -7,6 +7,7 @@ Documentation for rocRAND is available at

### Changed
* Updated several `gfx942` auto tuning parameters.
* Changed the C++ version from 14 to 17. C++14 will be deprecated in the next major release.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the deprecation notice should be moved to the "Upcoming changes" section (leave the part about changing the version here).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated it in 6b70e43. Also did a similar change for the PR for hipRAND.

@Naraenda Naraenda force-pushed the develop_stream_20250128 branch from 6b70e43 to 6c6e699 Compare January 30, 2025 10:42
…ream_20250128'

Deprecate sobol constants and vectors

See merge request amd/libraries/rocRAND!374
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants