Skip to content

Conversation

@rasolca
Copy link

@rasolca rasolca commented Nov 5, 2025

Motivation

Since cmake 3.21 HIP is a language in cmake.
cmake 3.31.8 doesn't support hip_add_executable and therefore the build fails.

Technical Details

HIP language has been enabled in the project.
device file gets the property LANGUAGE HIP to be compiled correctly.
compile options are now added with target_compile_options for both C++ and HIP (HIP workaround not needed anymore)
CMAKE_HIP_ARCHITECTURES is now used removing the need of manually handling the GPU architectures.

Test Plan and Result

Several cmake builds have been done to check the results of the configuration.
install.sh has been tested to ensure that the --archs option works as expected.

Submission Checklist

@rasolca rasolca requested a review from pbauman as a code owner November 5, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant