Fix CMakelists to support modern versions of cmake #28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Since cmake 3.21 HIP is a language in cmake.
cmake 3.31.8 doesn't support
hip_add_executableand therefore the build fails.Technical Details
HIP language has been enabled in the project.
device file gets the property
LANGUAGE HIPto be compiled correctly.compile options are now added with
target_compile_optionsfor both C++ and HIP (HIP workaround not needed anymore)CMAKE_HIP_ARCHITECTURESis now used removing the need of manually handling the GPU architectures.Test Plan and Result
Several cmake builds have been done to check the results of the configuration.
install.shhas been tested to ensure that the--archsoption works as expected.Submission Checklist