Add right-click copy to Track Details tables#903
Open
dhingora-amd wants to merge 1 commit into
Open
Conversation
Track Details rows now support right-click Copy Row Data / Copy Cell Data with copy notifications, matching the Event Details tab. Works on both the topology/track info tables and the computed stats rows (queue utilization, counter min/max/mean/stddev). Co-authored-by: Cursor <cursoragent@cursor.com>
dhingora-amd
requested review from
Sajeeth-Wimalasuriyan,
amokiche-amd,
drchen-amd and
tomk-amd
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| void | ||
| TrackDetails::RenderTable(InfoTable& table, const AnalysisTrackStatistics* stats) | ||
| TrackDetails::RenderTable(InfoTable& table, const char* table_id, |
drchen-amd
reviewed
Jun 25, 2026
| row_cells.push_back(cell.needs_format ? cell.formatted | ||
| : cell.data); | ||
| } | ||
| AddCopyRowCellMenuItems(row_cells.data(), cols, m_cell_menu.column); |
Member
There was a problem hiding this comment.
For the copy row case, this AddCopyRowCellMenuItems and whatever InfiniteScrollTable uses should use the same seperator.
Currently InfiniteScrollTable are comma seperated, but AddCopyRowCellMenuItems is space sepearted.
| } | ||
| } | ||
|
|
||
| const std::string ctx_menu_id = std::string(table_id) + "_ctx"; |
Member
There was a problem hiding this comment.
No need to build this string id. You can just define a constant id because there will only be one active at a time. It looks like this is the only user of table_id parameter, so that could be removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The Track Details tab had no way to copy its values. The Event Details
tab already supports right-click copy on its tables, so Track Details
was inconsistent and users couldn't easily grab a track's info or its
computed stats. This brings Track Details to parity.
Technical Details
Track Details rows now support a right-click context menu with "Copy Row
Data" / "Copy Cell Data", each raising the standard copy notification —
matching the Event Details tab.
rows (queue utilization, and counter min/max/mean/stddev).
gui_helpers(RenderRowHitbox,PositionCell,CaptureCellRightClick,BeginCellContextMenu,AddCopyRowCellMenuItems) added in Make Event Details table right-click hitboxes consistent and dedupe scaffolding #877, so no copy/menu/notificationlogic is duplicated.
and the stats rows share a single
CellMenuTargetvia an offset rowindex. Existing cell elide/expand behavior is preserved.