AMokichev/ Add new widget to show code and correspond it to the ISA#841
Open
amokiche-amd wants to merge 8 commits into
Open
AMokichev/ Add new widget to show code and correspond it to the ISA#841amokiche-amd wants to merge 8 commits into
amokiche-amd wants to merge 8 commits into
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
amokiche-amd
force-pushed
the
amokichev/code-to-isa-widget
branch
from
d0cf578 to
41039f1
Compare
one more file replace font stub by system font add control panel to the view prototype to draw the code show isa without connecting last changes add common state, but broke behavour fix selection + refactoring make code more readable data models with generated stubs refactor ProcessLoadComputeTrace Add new files to controller Read and send one field throught DB and controller refactor refactor LoadPCSamplingData function Fill source file structure Fill source lines fill isa lines refactor to get rid of id offset Load junctions Load stall records Get rid of stubs to load DB and use data provider for PC Sampling add chosing of source file from dropdawn fix split container and make splitter visible add stall reason count and move comment to another column
amokiche-amd
force-pushed
the
amokichev/code-to-isa-widget
branch
from
63f893d to
99a378d
Compare
amokiche-amd
requested review from
a team,
Sajeeth-Wimalasuriyan,
drchen-amd,
tomk-amd and
vstempen
as code owners
Member
|
I haven't tested/looked deeply yet, but it looks like all data is loaded once on initial file open? I think this use case warrants breaking up the data load into an initial discovery, followed by dynamically loading pieces driven by user input, like how the metrics how handled. I mention this because...
|
tomk-amd
reviewed
Jun 17, 2026
vstempen
reviewed
Jun 17, 2026
Contributor
Author
Now I think I should have done this in the next pull request, but since I'd already started, I finished it right away. So this functionality has been added. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
[Optiq-Compute] Add new widget to show code and correspond it to the ISA
Add the prototype for PC sampling view to analyze the code and ISA
Technical Details
A data model for PC sampling has been added, along with data loading from the database via a controller and populating the data model. This data model is then used to build the code for ISA View. To enable this, you must build the tool with the ROCPROFVIS_DEVELOPER_MODE flag.
The part of the code responsible for the stall is a stub; there is currently no clear picture of what it should look like.
Test Plan
Test Result
Submission Checklist