Skip to content

[BUILD] Fix build failure against rocm-6.0.0 #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codambro wants to merge 1 commit into
base: develop
Choose a base branch
from
+4 −4
Open

[BUILD] Fix build failure against rocm-6.0.0 #134

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions verifiable/verifiable.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,7 +392,7 @@ struct FloatLayout<hip_bfloat16> {
};
#endif
#if RCCL_FLOAT8 == 1
#if __HIP_DEVICE_COMPILE__ || HIP_VERSION < 60300000
#if __HIP_DEVICE_COMPILE__ || (HIP_VERSION >= 60200000 && HIP_VERSION < 60300000)
template<>
struct FloatLayout<rccl_float8> {
static constexpr bool is_floating_point = true;
Expand Down Expand Up @@ -993,7 +993,7 @@ cudaError_t prepareInput1(
#if HAVE_ncclBfloat16
case ncclBfloat16: fn = (void const*)&prepareInput2<hip_bfloat16, ReduceOp>; break;
#endif
#if HAVE_ncclfp8_DEVICE || HIP_VERSION < 60300000
#if HAVE_ncclfp8_DEVICE || (HIP_VERSION >= 60200000 && HIP_VERSION < 60300000)
case ncclFloat8e4m3: fn = (void const*)&prepareInput2<rccl_float8, ReduceOp>; break;
case ncclFloat8e5m2: fn = (void const*)&prepareInput2<rccl_bfloat8, ReduceOp>; break;
#elif HAVE_ncclfp8_HOST
Expand Down Expand Up @@ -1083,7 +1083,7 @@ cudaError_t prepareExpected1(
#if HAVE_ncclBfloat16
case ncclBfloat16: fn = (void const*)&prepareExpected2<hip_bfloat16, ReduceOp>; break;
#endif
#if HAVE_ncclfp8_DEVICE || HIP_VERSION < 60300000 //for backward compatibility
#if HAVE_ncclfp8_DEVICE || (HIP_VERSION >= 60200000 && HIP_VERSION < 60300000)
case ncclFloat8e4m3: fn = (void const*)&prepareExpected2<rccl_float8, ReduceOp>; break;
case ncclFloat8e5m2: fn = (void const*)&prepareExpected2<rccl_bfloat8, ReduceOp>; break;
#elif HAVE_ncclfp8_HOST
Expand Down Expand Up @@ -1321,7 +1321,7 @@ hipError_t ncclVerifiableVerify(
#if HAVE_ncclBfloat16
case ncclBfloat16: CASE_TY(hip_bfloat16, uint16_t)
#endif
#if HAVE_ncclfp8_DEVICE || HIP_VERSION < 60300000
#if HAVE_ncclfp8_DEVICE || (HIP_VERSION >= 60200000 && HIP_VERSION < 60300000)
case ncclFloat8e4m3: CASE_TY(rccl_float8, uint8_t)
case ncclFloat8e5m2: CASE_TY(rccl_bfloat8, uint8_t)
#elif HAVE_ncclfp8_HOST
Expand Down