Skip to content

[AllReduce] Enable FP8 conditions only if FP8 is supported #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
nileshnegi wants to merge 1 commit into
base: develop
Choose a base branch
from
+4 −0
Draft

[AllReduce] Enable FP8 conditions only if FP8 is supported #104

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/all_reduce.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,10 @@ testResult_t AllReduceRunTest(struct threadArgs* args, int root, ncclDataType_t
ncclRedOp_t *run_ops;
const char **run_typenames, **run_opnames;
int type_count, op_count;
#if defined(RCCL_FLOAT8)
if((type == ncclFp8E4M3 || type == ncclFp8E5M2) && op == ncclProd)
return testSuccess;
#endif

if ((int)type != -1) {
type_count = 1;
Expand All @@ -90,8 +92,10 @@ testResult_t AllReduceRunTest(struct threadArgs* args, int root, ncclDataType_t

for (int i=0; i<type_count; i++) {
for (int j=0; j<op_count; j++) {
#if defined(RCCL_FLOAT8)
if((i == ncclFp8E4M3 || i == ncclFp8E5M2) && j == ncclProd)
continue;
#endif
TESTCHECK(TimeTest(args, run_types[i], run_typenames[i], run_ops[j], run_opnames[j], -1));
}
}
Expand Down