update confgs in tests to use helper functions#69
Merged
Conversation
1cebbc2 to
14a6d6b
Compare
05a8a4e to
4be1b81
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There were new UTs added to upstream, and they do not have decoupled config helper function usage. This PR adds that
Tests
Ran all the tests using:
.venv_rocm_jax082_decoupled/bin/python3 -m pytest -m decoupled -v tests --csv=decoupled-tests-report.csv --html=decoupled-tests-report.html --self-contained-html 2>&1 | tee maxtext_decoupled_UT.logNo tests fail with config errors.
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.